[flutter_markdown] Custom fontfeature superscript#5874
Merged
auto-submit[bot] merged 9 commits intoflutter:mainfrom Apr 19, 2024
Merged
[flutter_markdown] Custom fontfeature superscript#5874auto-submit[bot] merged 9 commits intoflutter:mainfrom
auto-submit[bot] merged 9 commits intoflutter:mainfrom
Conversation
domesticmouse
approved these changes
Jan 12, 2024
Contributor
Author
|
@domesticmouse is there any blocker to merge it? |
Contributor
|
PTAL @stuartmorgan |
tarrinneal
requested changes
Feb 21, 2024
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
looks good with a changelog style update.
Collaborator
|
@dawidope Is this PR still something you are planning on updating to make it landable? |
# Conflicts: # packages/flutter_markdown/CHANGELOG.md # packages/flutter_markdown/lib/src/style_sheet.dart # packages/flutter_markdown/pubspec.yaml
Contributor
Author
|
@stuartmorgan I have done all requested changes. I hope that the changelog follows rules now. |
tarrinneal
approved these changes
Apr 18, 2024
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
Seems good once you bump the version number and handle the conflicts.
# Conflicts: # packages/flutter_markdown/CHANGELOG.md # packages/flutter_markdown/pubspec.yaml
Contributor
Author
|
Done. Thanks! |
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@88a3a56...01a32c4 2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/packages#6587) 2024-04-21 [email protected] Roll Flutter from 98685a0 to 1a905d5 (30 revisions) (flutter/packages#6583) 2024-04-19 [email protected] [flutter_markdown] Custom fontfeature superscript (flutter/packages#5874) 2024-04-19 [email protected] Roll Flutter from fb110b9 to 98685a0 (28 revisions) (flutter/packages#6577) 2024-04-19 [email protected] Roll Flutter (stable) from 300451a to 54e6646 (1 revision) (flutter/packages#6575) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@88a3a56...01a32c4 2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/packages#6587) 2024-04-21 [email protected] Roll Flutter from 98685a0 to 1a905d5 (30 revisions) (flutter/packages#6583) 2024-04-19 [email protected] [flutter_markdown] Custom fontfeature superscript (flutter/packages#5874) 2024-04-19 [email protected] Roll Flutter from fb110b9 to 98685a0 (28 revisions) (flutter/packages#6577) 2024-04-19 [email protected] Roll Flutter (stable) from 300451a to 54e6646 (1 revision) (flutter/packages#6575) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Fix not solved issue from another PR: flutter#5058 (comment). I chose the 2nd option with custom font feature.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix not solved issue from another PR: #5058 (comment).
I chose the 2nd option with custom font feature.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).