[ci] Run check_podspecs on arm Mac bots#5885
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Jan 16, 2024
Merged
Conversation
stuartmorgan-g
approved these changes
Jan 13, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, although I would prefer adjusting the PR to add a new arm64 copy, and then remove the x64 copy when taking this out of bringup, so that we don't have a coverage gap.
.ci.yaml
Outdated
| # support. `pod lint` makes a synthetic target that doesn't respect the | ||
| # pod's arch exclusions, so fails to build. | ||
| - name: Mac_x64 check_podspecs | ||
| - name: Mac_arm64 check_podspecs |
Collaborator
There was a problem hiding this comment.
Per discussion in the other issue, you could rename this repo_checks now to save another 2-PR cycle later.
Member
Author
Done. |
jmagman
commented
Jan 16, 2024
| properties: | ||
| add_recipes_cq: "true" | ||
| version_file: flutter_master.version | ||
| target_file: macos_check_podspecs.yaml |
Member
Author
There was a problem hiding this comment.
I'll rename to macos_repo_checks.yaml once Mac_x64 check_podspecs is removed and it's not shared, or I'll use repo_checks.yaml but do something to bifurcate the platforms, tbd.
jmagman
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/5885, due to - The status or check suite Linux_android android_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jmagman
added
the
autosubmit
This was referenced Jan 16, 2024
jmagman
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
This reverts commit 855e283.
11 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jan 17, 2024
Reverts #5885 Initiated by: jmagman This change reverts the following previous change: Original Description: Fixes flutter/flutter#141493
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 17, 2024
flutter/packages@7dd0fcb...1a2b780 2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Run check_podspecs on arm Mac bots" (flutter/packages#5909) 2024-01-17 [email protected] [various] Update minimum iOS versions to 12.0 (flutter/packages#5902) 2024-01-16 [email protected] [ci] Run check_podspecs on arm Mac bots (flutter/packages#5885) 2024-01-16 [email protected] [pigeon] Fix pigeon test generation missing wrapResponse method. (flutter/packages#5903) 2024-01-16 [email protected] Roll Flutter from 1a2c315 to 8e94423 (2 revisions) (flutter/packages#5897) 2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/packages#5896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
12 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#141493
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.