[pigeon] Fix pigeon test generation missing wrapResponse method.#5903
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Jan 16, 2024
Merged
[pigeon] Fix pigeon test generation missing wrapResponse method.#5903auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
tarrinneal
approved these changes
Jan 16, 2024
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
Thanks for throwing this together! I would say this is probably indicative of a need for more tests using this test output, but I think the dartTest output is potentially on it's way out.
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 17, 2024
flutter/packages@7dd0fcb...1a2b780 2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Run check_podspecs on arm Mac bots" (flutter/packages#5909) 2024-01-17 [email protected] [various] Update minimum iOS versions to 12.0 (flutter/packages#5902) 2024-01-16 [email protected] [ci] Run check_podspecs on arm Mac bots (flutter/packages#5885) 2024-01-16 [email protected] [pigeon] Fix pigeon test generation missing wrapResponse method. (flutter/packages#5903) 2024-01-16 [email protected] Roll Flutter from 1a2c315 to 8e94423 (2 revisions) (flutter/packages#5897) 2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/packages#5896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
12 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pigeon was not generating the wrapResponse method, and therefore failing compilation of the generated tests.
Fixes: flutter/flutter#141499
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).