[camerax] Wrap Android classes/methods required to set the exposure mode#5966
Merged
auto-submit[bot] merged 25 commits intoflutter:mainfrom Feb 5, 2024
Merged
[camerax] Wrap Android classes/methods required to set the exposure mode#5966auto-submit[bot] merged 25 commits intoflutter:mainfrom
auto-submit[bot] merged 25 commits intoflutter:mainfrom
Conversation
bartekpacia
reviewed
Jan 23, 2024
packages/camera/camera_android_camerax/lib/src/camera2_camera_control.dart
Outdated
Show resolved
Hide resolved
…control.dart Co-authored-by: Bartek Pacia <[email protected]>
gmackall
reviewed
Feb 3, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
Mostly lgtm, just a couple of minor comments!
...amerax/android/src/main/java/io/flutter/plugins/camerax/Camera2CameraControlHostApiImpl.java
Outdated
Show resolved
Hide resolved
...amerax/android/src/main/java/io/flutter/plugins/camerax/Camera2CameraControlHostApiImpl.java
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/src/camera2_camera_control.dart
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/src/camera2_camera_control.dart
Outdated
Show resolved
Hide resolved
| /// was previously set, these options will override those pre-existing. Once | ||
| /// merged, these values will be submitted with every repeating and single | ||
| /// capture requests issued by CameraX. | ||
| Future<void> addCaptureRequestOptions( |
Member
There was a problem hiding this comment.
non blocking: This PR is just wrapping the classes, but I am curious: Will we not need clearCaptureRequestOptions wrapped to return to an "unset exposure mode" state? Or does setting all the previously set options to null have the same effect?
Contributor
Author
There was a problem hiding this comment.
I am not 100% sure that we don't need it, but I was just going to wrap it later if I do.
My understanding, though, is that using clearCaptureRequestOption, which I wrap for CaptureRequestOptions has the same effect, so that's why I didn't worry about it for now.
packages/camera/camera_android_camerax/pigeons/camerax_library.dart
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/src/capture_request_options.dart
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/src/capture_request_options.dart
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/src/capture_request_options.dart
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/test/capture_request_options_test.dart
Outdated
Show resolved
Hide resolved
…o/flutter/plugins/camerax/Camera2CameraControlHostApiImpl.java Co-authored-by: Gray Mackall <[email protected]>
…control.dart Co-authored-by: Gray Mackall <[email protected]>
…control.dart Co-authored-by: Gray Mackall <[email protected]>
…_options.dart Co-authored-by: Gray Mackall <[email protected]>
….dart Co-authored-by: Gray Mackall <[email protected]>
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 6, 2024
flutter/packages@ae3494d...1a5a7ce 2024-02-05 [email protected] [camerax] Wrap Android classes/methods required to set the exposure mode (flutter/packages#5966) 2024-02-05 [email protected] Manual roll Flutter from e02e207 to 0b5cd50 (46 revisions) (flutter/packages#6053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps classes/methods needed to set capture request options that will allow us to implement setting the exposure mode, namely:
Camera2CameraControl
createmethod usingfromsetCaptureRequestOptionsCaptureRequestOptions
createmethod using its builder*Part of flutter/flutter#120468.
*Note that this required that I specify types of supported capture request options due to the Dart/native split. I took inspiration from our previous implementation of supported
LiveDatatypes (see pigeon file for details).Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).