[two_dimensional_scrollables] Fix TableView example#6154
Closed
IchordeDionysos wants to merge 1 commit intoflutter:mainfrom
Closed
[two_dimensional_scrollables] Fix TableView example#6154IchordeDionysos wants to merge 1 commit intoflutter:mainfrom
IchordeDionysos wants to merge 1 commit intoflutter:mainfrom
Conversation
Piinks
reviewed
Feb 22, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Thank you for sending a PR! I think this definitely warrants a release, poor docs are never helpful. :)
Can you update the pubspec and changelog with a minor version bump?
Piinks
added
the
p: two_dimensional_scrollables
Merged
11 tasks
Contributor
|
Hey @IchordeDionysos, since we haven't heard back here, I included this fix in #6283. |
Contributor
Author
|
Hey @Piinks sorry this fell under the table :) |
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
…rged TableViewCells (#6283) Fixes flutter/flutter#144100 Picks up doc fix from #6154 as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TableViewrequires the cell to be wrapped in aTableViewCell. Simply returning any other widget will not work.Not sure if we need a new release for this? Or if it's fine to be pushed with the next release?!
/cc @Piinks
Pre-launch Checklist
dart format.)[shared_preferences]I updatedpubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.I updatedCHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.