[image_picker] Fix If imageToScale is nil, the app will crash (#146682)#6514
Merged
auto-submit[bot] merged 6 commits intoflutter:mainfrom Apr 22, 2024
Merged
[image_picker] Fix If imageToScale is nil, the app will crash (#146682)#6514auto-submit[bot] merged 6 commits intoflutter:mainfrom
auto-submit[bot] merged 6 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
vashworth
reviewed
Apr 18, 2024
packages/image_picker/image_picker_ios/example/ios/RunnerTests/ImageUtilTests.m
Show resolved
Hide resolved
vashworth
approved these changes
Apr 19, 2024
Contributor
vashworth
left a comment
vashworth
left a comment
There was a problem hiding this comment.
Thanks for the contribution! LGTM
tarrinneal
approved these changes
Apr 22, 2024
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 23, 2024
flutter/packages@01a32c4...cf6d280 2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.2 to 4.3.3 (flutter/packages#6598) 2024-04-22 [email protected] [image_picker] Fix If imageToScale is nil, the app will crash (#146682) (flutter/packages#6514) 2024-04-22 [email protected] Roll Flutter from 1a905d5 to 140edb9 (5 revisions) (flutter/packages#6594) 2024-04-22 [email protected] [pointer_interceptor_web] Remove semantic tests. (flutter/packages#6580) 2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/packages#6571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…2) (flutter#6514) Fix flutter/flutter#146682 Pre-launch Checklist
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flutter/flutter#146682
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.