[image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios#6617
Merged
auto-submit[bot] merged 9 commits intoflutter:mainfrom May 8, 2024
Merged
Conversation
stuartmorgan-g
approved these changes
May 6, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one small fix.
| name: "image_picker_ios", | ||
| platforms: [ | ||
| .iOS("12.0"), | ||
| .macOS("10.14"), |
Collaborator
There was a problem hiding this comment.
No macOS for this one.
Contributor
Author
There was a problem hiding this comment.
I'll remove it so there's less confusion, but just FYI this doesn't really do much. From my testing (I can't find any documentation on it), if a specific platform is left out of this list, SwiftPM will just assume the minimum version. It doesn't exclude it by platform or anything cool like that unfortunately - that could change, though
vashworth
added
the
autosubmit
Contributor
Author
|
Reason for revert: Failing Mac_arm64 ios_platform_tests_shard_1 master |
vashworth
added
the
revert
11 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
May 8, 2024
…to image_picker_ios (#6617)" (#6693) Reverts: #6617 Initiated by: vashworth Reason for reverting: Failing [Mac_arm64 ios_platform_tests_shard_1 master](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20ios_platform_tests_shard_1%20master/1942/overview) Original PR Author: vashworth Reviewed By: {loic-sharma, stuartmorgan} This change reverts the following previous change: Makes `image_picker_ios` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods. Fixes flutter/flutter#146919.
vashworth
added a commit
to vashworth/packages
that referenced
this pull request
May 8, 2024
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2024
…o image_picker_ios (flutter/packages#6617)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2024
…o image_picker_ios (flutter/packages#6617)
auto-submit bot
pushed a commit
that referenced
this pull request
May 9, 2024
Relands #6617. Was reverted in hopes of fixing flutter/flutter#148003, but ended up being fixed by #6694.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2024
…o image_picker_ios (flutter/packages#6617)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 10, 2024
flutter/packages@8de142d...6c4482a 2024-05-09 [email protected] [image_picker_ios] Adds Swift Package Manager compatibility (flutter/packages#6696) 2024-05-09 [email protected] [flutter_lints] Rev to 4.0.0; prepare for publishing (flutter/packages#6695) 2024-05-09 [email protected] [pointer_interceptor] Remove `implements` from app-facing package (flutter/packages#6699) 2024-05-08 [email protected] Temporarily add empty header files to video_player_avfoundation so include directory is downloaded (flutter/packages#6694) 2024-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios (#6617)" (flutter/packages#6693) 2024-05-08 [email protected] [image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios (flutter/packages#6617) 2024-05-08 [email protected] [video_player_avfoundation] Adds Swift Package Manager compatibility (flutter/packages#6675) 2024-05-08 [email protected] [ios_platform_images] Add Swift Package Manager support (flutter/packages#6684) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…picker_ios (flutter#6617) Makes `image_picker_ios` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods. Fixes flutter/flutter#146919.
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…to image_picker_ios (flutter#6617)" (flutter#6693) Reverts: flutter#6617 Initiated by: vashworth Reason for reverting: Failing [Mac_arm64 ios_platform_tests_shard_1 master](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20ios_platform_tests_shard_1%20master/1942/overview) Original PR Author: vashworth Reviewed By: {loic-sharma, stuartmorgan} This change reverts the following previous change: Makes `image_picker_ios` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods. Fixes flutter/flutter#146919.
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…6696) Relands flutter#6617. Was reverted in hopes of fixing flutter/flutter#148003, but ended up being fixed by flutter#6694.
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
May 31, 2024
Adds Swift Package Manager compatibility to `image_picker_ios`. The previous attempt, #6617, was partially reverted due to flutter/flutter#148307. This reland uses the new approach proposed in flutter/flutter#148572: the Swift Package Manager package does not have a `.modulemap`. As a result, the plugin no longer has a `.Test` submodule if using Swift Package Manager. Fixes flutter/flutter#146919.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
image_picker_iosavailable as a Swift Package to Flutter. Also, remains compatible with CocoaPods.Fixes flutter/flutter#146919.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.