[pointer_interceptor] Remove `implements` from app-facing package by bparrishMines · Pull Request #6699 · flutter/packages

bparrishMines · 2024-05-09T00:43:41Z

Dart unit tests started failing for pointer_interceptor due to the implements tag in the app facing package. This plugin is federated for ios and web, so it looks like the error message is valid.

Plugin pointer_interceptor:ios provides an implementation for pointer_interceptor_platform_interface and also references a default implementation for pointer_interceptor_ios, which is currently not supported. Ask the maintainers of pointer_interceptor to either remove the implementation via `implements: pointer_interceptor_platform_interface` or avoid referencing a default implementation via `platforms: ios: default_package: pointer_interceptor_ios`.


00:00 +0 -1: loading /b/s/w/ir/x/w/packages/packages/pointer_interceptor/pointer_interceptor/test/tests_exist_elsewhere_test.dart [E]                                                                  
  Error: Please resolve the plugin pubspec errors
  package:flutter_tools/src/base/common.dart 10:3          throwToolExit
  package:flutter_tools/src/flutter_plugins.dart 1214:5    resolvePlatformImplementation
  package:flutter_tools/src/flutter_plugins.dart 1418:55   generateMainDartWithPluginRegistrant
  ===== asynchronous gap ===========================
  package:flutter_tools/src/test/test_compiler.dart 163:9  TestCompiler._onCompilationRequest
  
  TimeoutException after 0:12:00.000000: Test timed out after 12 minutes.
  package:test_api/src/backend/invoker.dart 338:28  Invoker._handleError.<fn>
  dart:async/zone.dart 1391:47                      _rootRun
  dart:async/zone.dart 1301:19                      _CustomZone.run
  package:test_api/src/backend/invoker.dart 336:10  Invoker._handleError
  package:test_api/src/backend/invoker.dart 291:9   Invoker.heartbeat.<fn>.<fn>
  dart:async/zone.dart 1399:13                      _rootRun
  dart:async/zone.dart 1301:19                      _CustomZone.run
  package:test_api/src/backend/invoker.dart 290:38  Invoker.heartbeat.<fn>
  dart:async-patch/timer_patch.dart 18:15           Timer._createTimer.<fn>
  dart:isolate-patch/timer_impl.dart 398:19         _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 429:5          _Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 184:12      _RawReceivePort._handleMessage
  

To run this test again: /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test

This removes the tag and does a manual roll.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ditman

LGTM, good fix! This must be a new check, because federation happened a while ago (?)

ditman · 2024-05-09T02:01:39Z

packages/pointer_interceptor/pointer_interceptor/CHANGELOG.md

 * Updates support matrix in README to indicate that iOS 11 is no longer supported.
 * Clients on versions of Flutter that still support iOS 11 can continue to use this
  package with iOS 11, but will not receive any further updates to the iOS implementation.
+* Removes invalid `implements` tag in pubspec.


Publishing for this change could be omitted, I think?

Yea, I wasn't sure whether this affected clients or not. I did it just in case.

Gustl22 · 2024-05-09T05:51:03Z

This must be a new check, because federation happened a while ago (?)

Yes, this error message was introduced in flutter/flutter#145258, because the exisiting plugin resolution did allow this despite having an inconsistent dependency tree.

Thanks for applying this!

…kage (flutter/packages#6699)

ditman · 2024-05-09T20:47:07Z

@Gustl22 thanks for adding this, I totally didn't catch the inconsistency during manual review!

flutter/packages@8de142d...6c4482a 2024-05-09 [email protected] [image_picker_ios] Adds Swift Package Manager compatibility (flutter/packages#6696) 2024-05-09 [email protected] [flutter_lints] Rev to 4.0.0; prepare for publishing (flutter/packages#6695) 2024-05-09 [email protected] [pointer_interceptor] Remove `implements` from app-facing package (flutter/packages#6699) 2024-05-08 [email protected] Temporarily add empty header files to video_player_avfoundation so include directory is downloaded (flutter/packages#6694) 2024-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios (#6617)" (flutter/packages#6693) 2024-05-08 [email protected] [image_picker_ios] Adds Swift Package Manager compatibility to image_picker_ios (flutter/packages#6617) 2024-05-08 [email protected] [video_player_avfoundation] Adds Swift Package Manager compatibility (flutter/packages#6675) 2024-05-08 [email protected] [ios_platform_images] Add Swift Package Manager support (flutter/packages#6684) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter#6699) Dart unit tests started failing for `pointer_interceptor` due to the `implements` tag in the app facing package. This plugin is federated for ios and web, so it looks like the error message is valid. ``` Plugin pointer_interceptor:ios provides an implementation for pointer_interceptor_platform_interface and also references a default implementation for pointer_interceptor_ios, which is currently not supported. Ask the maintainers of pointer_interceptor to either remove the implementation via `implements: pointer_interceptor_platform_interface` or avoid referencing a default implementation via `platforms: ios: default_package: pointer_interceptor_ios`. 00:00 +0 -1: loading /b/s/w/ir/x/w/packages/packages/pointer_interceptor/pointer_interceptor/test/tests_exist_elsewhere_test.dart [E] Error: Please resolve the plugin pubspec errors package:flutter_tools/src/base/common.dart 10:3 throwToolExit package:flutter_tools/src/flutter_plugins.dart 1214:5 resolvePlatformImplementation package:flutter_tools/src/flutter_plugins.dart 1418:55 generateMainDartWithPluginRegistrant ===== asynchronous gap =========================== package:flutter_tools/src/test/test_compiler.dart 163:9 TestCompiler._onCompilationRequest TimeoutException after 0:12:00.000000: Test timed out after 12 minutes. package:test_api/src/backend/invoker.dart 338:28 Invoker._handleError.<fn> dart:async/zone.dart 1391:47 _rootRun dart:async/zone.dart 1301:19 _CustomZone.run package:test_api/src/backend/invoker.dart 336:10 Invoker._handleError package:test_api/src/backend/invoker.dart 291:9 Invoker.heartbeat.<fn>.<fn> dart:async/zone.dart 1399:13 _rootRun dart:async/zone.dart 1301:19 _CustomZone.run package:test_api/src/backend/invoker.dart 290:38 Invoker.heartbeat.<fn> dart:async-patch/timer_patch.dart 18:15 Timer._createTimer.<fn> dart:isolate-patch/timer_impl.dart 398:19 _Timer._runTimers dart:isolate-patch/timer_impl.dart 429:5 _Timer._handleMessage dart:isolate-patch/isolate_patch.dart 184:12 _RawReceivePort._handleMessage To run this test again: /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test ``` This removes the tag and does a manual roll.

remove implements from pointer_interceptor

2704c0c

bparrishMines requested a review from ditman as a code owner May 9, 2024 00:43

github-actions bot added the p: pointer_interceptor label May 9, 2024

Merge branch 'main' of github.com:flutter/packages into fix_pi

d29afc0

bparrishMines changed the title ~~remove implements from pointer_interceptor~~ [pointer_interceptor] Remove implements from app-facing package May 9, 2024

bparrishMines changed the title ~~[pointer_interceptor] Remove implements from app-facing package~~ [pointer_interceptor] Remove implements from app-facing package May 9, 2024

ditman approved these changes May 9, 2024

View reviewed changes

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024

auto-submit bot merged commit 4e79678 into flutter:main May 9, 2024

bparrishMines deleted the fix_pi branch May 9, 2024 02:28

engine-flutter-autoroll mentioned this pull request May 9, 2024

Roll Packages from 8de142d33b88 to 4e796783a265 (6 revisions) flutter/flutter#148059

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2024

4e79678 [pointer_interceptor] Remove implements from app-facing pac…

e977e24

…kage (flutter/packages#6699)

engine-flutter-autoroll mentioned this pull request May 9, 2024

Roll Packages from 8de142d33b88 to 4799c4963496 (7 revisions) flutter/flutter#148068

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2024

4e79678 [pointer_interceptor] Remove implements from app-facing pac…

9135e58

…kage (flutter/packages#6699)

engine-flutter-autoroll mentioned this pull request May 9, 2024

Roll Packages from 8de142d33b88 to 6c4482a64492 (8 revisions) flutter/flutter#148079

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 9, 2024

4e79678 [pointer_interceptor] Remove implements from app-facing pac…

40711e4

…kage (flutter/packages#6699)

reidbaker mentioned this pull request Jul 2, 2024

i151188 update espresso dependencies v2 reidbaker/packages#6

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pointer_interceptor] Remove `implements` from app-facing package#6699

[pointer_interceptor] Remove `implements` from app-facing package#6699
auto-submit[bot] merged 2 commits intoflutter:mainfrom
bparrishMines:fix_pi

bparrishMines commented May 9, 2024 •

edited

Loading

Uh oh!

ditman left a comment

Uh oh!

ditman May 9, 2024

Uh oh!

bparrishMines May 9, 2024

Uh oh!

Gustl22 commented May 9, 2024

Uh oh!

ditman commented May 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bparrishMines commented May 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

ditman May 9, 2024

Choose a reason for hiding this comment

Uh oh!

bparrishMines May 9, 2024

Choose a reason for hiding this comment

Uh oh!

Gustl22 commented May 9, 2024

Uh oh!

ditman commented May 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bparrishMines commented May 9, 2024 •

edited

Loading