[ci][web] Run tests in canvaskit mode. by mdebbar · Pull Request #6879 · flutter/packages

mdebbar · 2024-06-06T17:45:50Z

Configures the flutter/packages CI to run web tests using the canvaskit renderer, which is the new default for web apps.

It also does some minor changes:

Skips tests on the web for package:palette_generator (cleanup issue created below)
- Makes the palette_generator example run on the web. This was used to manually verify that the package still works as expected with canvaskit.
Tweaks the README of the pointer_interceptor example apps, so they match what's happening in there.

Issues

Fixes Web tests in flutter/packages repo only test against HTML renderer flutter#143543

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Co-authored-by: David Iglesias [email protected]

ditman · 2024-06-11T21:46:08Z

(Linux_android android_platform_tests_shard_6 master is a known flake, I've restarted it)

ditman · 2024-06-11T22:22:17Z

dit@dit:/work/flutter/packages/packages/palette_generator$ flutter test --color --platform=chrome --web-renderer=canvaskit -v
...
[   +1 ms] Launching Chromium (url = http://localhost:40285/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A40285%2F0&debug=false, headless = true,
skipCheck = false, debugPort = null)
[   +1 ms] Will use Chromium executable at google-chrome
[  +87 ms] Using Google Chrome 126.0.6478.55 

[ +210 ms] [CHROME]: 
[        ] [CHROME]: DevTools listening on ws://127.0.0.1:34627/devtools/browser/2bef8322-20d8-4960-8577-5f04f53770d2
[ +187 ms] Running test suite test/palette_generator_test.dart.
00:04 +15: PaletteTarget == does not crash on invalid comparisons                                                                                              [+3491 ms] Shutting down Chromium.
00:04 +15: All tests passed!
...

~~I have a suspicion that the version of Chrome we're using in CI for flutter test may be a little bit too old, I haven't been able to reproduce the failure locally.~~

CI is using:

Chromium 114.0.5735.0

ditman · 2024-06-11T23:01:32Z

Running with Chrome For Testing 114...

dit@dit:/work/flutter/packages/packages/palette_generator$ CHROME_EXECUTABLE=/work/flutter/packages/packages/palette_generator/chrome-linux64/chrome flutter test --platform chrome --web-renderer canvaskit -v
...
[   +1 ms] Launching Chromium (url = http://localhost:45565/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A45565%2F0&debug=false, headless = true,
skipCheck = false, debugPort = null)
[   +1 ms] Will use Chromium executable at /work/flutter/packages/packages/palette_generator/chrome-linux64/chrome
[  +58 ms] Using Google Chrome for Testing 114.0.5696.0 
[ +122 ms] [CHROME]: 
[   +1 ms] [CHROME]: DevTools listening on ws://127.0.0.1:39723/devtools/browser/80547466-8479-4fe4-b64d-2bf927a1aed7
[ +204 ms] Running test suite test/palette_generator_test.dart.
00:03 +15: PaletteTarget == does not crash on invalid comparisons                                                                                              [+3480 ms] Shutting down Chromium.
00:03 +15: All tests passed!

Running with an older version of Chromium also passes:

dit@dit:/work/flutter/packages/packages/palette_generator$ CHROME_EXECUTABLE=/work/flutter/packages/packages/palette_generator/chromium-linux64/chrome flutter test --platform chrome --web-renderer canvaskit -v
...
[   +1 ms] Launching Chromium (url = http://localhost:44353/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A44353%2F0&debug=false, headless = true,
skipCheck = false, debugPort = null)
[   +1 ms] Will use Chromium executable at /work/flutter/packages/packages/palette_generator/chromium-linux64/chrome
[  +51 ms] Using Chromium 113.0.5672.127 

[ +124 ms] [CHROME]: 
[   +1 ms] [CHROME]: DevTools listening on ws://127.0.0.1:43267/devtools/browser/9c8eafc4-90d4-44fd-925f-2bf667e20cf2
[ +220 ms] Running test suite test/palette_generator_test.dart.
00:04 +15: PaletteTarget == does not crash on invalid comparisons                                                                                              [+4123 ms] Shutting down Chromium.
00:04 +15: All tests passed!

ditman · 2024-06-12T01:54:10Z

Tried running the example app in the browser with --web-renderer canvaskit, and it seems to be working just fine. Also tried with the --disable-gpu chrome command-line flag, but no change either.

Here's what the example app looks like on the web (right) vs an android emulator (left):

mdebbar · 2024-06-12T15:56:39Z

I, too, haven't been able to reproduce the failure locally.

ditman · 2024-06-25T23:36:51Z

Rebased (and force-pushed) to get some fresh results

ditman · 2024-07-09T21:14:42Z

Working to land this one this week.

ditman · 2024-07-09T22:38:58Z

The repo checks are flagging that there's a missing CHANGELOG entry in pointer_interceptor, however we're only changing the README of the example app, which doesn't get published anywhere. I'm skipping that check.

The following packages had errors:
  packages/pointer_interceptor/pointer_interceptor:
    Missing CHANGELOG change

ditman · 2024-07-09T23:53:40Z

Created issue to track re-enabling tests for palette_generator on the web:

[palette_generator][web] Reenable web tests. flutter#151498

ditman · 2024-07-10T00:44:29Z

PTAL @stuartmorgan!

stuartmorgan-g

LGTM with small suggestions.

packages/palette_generator/test/disabled_canvaskit_test.dart

packages/pointer_interceptor/pointer_interceptor_web/example/README.md

packages/palette_generator/test/palette_generator_test.dart

gspencergoog

flutter/packages@ea35fc6...3379e51 2024-07-12 [email protected] [pigeon] Fix C++ enum naming (flutter/packages#7094) 2024-07-12 [email protected] [ci] Split build_all_packages by JDK version. (flutter/packages#7106) 2024-07-12 [email protected] [ios]Fix compile error when conforming UIApplication to Launcher due to MainActor annotation (flutter/packages#7100) 2024-07-11 [email protected] [go_router] Makes GoRouterState lookup more robust. (flutter/packages#6920) 2024-07-11 [email protected] [ci][web] Run tests in canvaskit mode. (flutter/packages#6879) 2024-07-10 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/image_picker/image_picker_android/android (flutter/packages#6648) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the p: pointer_interceptor label Jun 6, 2024

ditman self-assigned this Jun 6, 2024

ditman force-pushed the tests_canvaskit branch from 059f442 to 945936d Compare June 25, 2024 23:35

[web][tests] Run tests in canvaskit mode

142049c

ditman force-pushed the tests_canvaskit branch from 945936d to 142049c Compare July 9, 2024 21:22

Fixes the example README for pointer_interceptor and _web.

73012ae

github-actions bot added the platform-web label Jul 9, 2024

ditman added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jul 9, 2024

ditman mentioned this pull request Jul 9, 2024

[palette_generator][web] Reenable web tests. flutter/flutter#151498

Closed

ditman added 2 commits July 9, 2024 16:52

Disable palette generator tests in the web.

2a8d04c

Make the example app run on the web.

c401fda

github-actions bot added the p: palette_generator label Jul 9, 2024

ditman requested a review from stuartmorgan-g July 10, 2024 00:10

ditman marked this pull request as ready for review July 10, 2024 00:10

ditman requested review from ditman and gspencergoog as code owners July 10, 2024 00:10

ditman changed the title ~~[web][tests] Run tests in canvaskit mode~~ [ci][web] Run tests in canvaskit mode. Jul 10, 2024

ditman added 2 commits July 9, 2024 17:21

Appease repo_checks for palette_generator changes.

b04aced

Add dummy file so *some* tests run on the web.

4b10279

Try again, saving the file this time!

fcfb069

stuartmorgan-g approved these changes Jul 10, 2024

View reviewed changes

packages/palette_generator/test/disabled_canvaskit_test.dart Outdated Show resolved Hide resolved

packages/pointer_interceptor/pointer_interceptor_web/example/README.md Outdated Show resolved Hide resolved

ditman added 2 commits July 10, 2024 12:38

Omit tests with dart_test.yaml config instead of an empty file.

d960620

Link to Flutter Plugin Tools docs to run tests.

a60975b

stuartmorgan-g approved these changes Jul 10, 2024

View reviewed changes

packages/palette_generator/test/palette_generator_test.dart Outdated Show resolved Hide resolved

Remove TestOn from file now that it is globally configured.

a62a060

gspencergoog approved these changes Jul 11, 2024

View reviewed changes

ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2024

auto-submit bot merged commit da04812 into flutter:main Jul 11, 2024

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Packages from ea35fc6fb86a to 26779818266e (5 revisions) flutter/flutter#151658

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 12, 2024

da04812 [ci][web] Run tests in canvaskit mode. (flutter/packages#6879)

6a8fe1f

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Packages from ea35fc6fb86a to 26779818266e (5 revisions) flutter/flutter#151673

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 12, 2024

da04812 [ci][web] Run tests in canvaskit mode. (flutter/packages#6879)

40f51ce

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Packages from ea35fc6fb86a to 3379e51a042a (6 revisions) flutter/flutter#151676

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 12, 2024

da04812 [ci][web] Run tests in canvaskit mode. (flutter/packages#6879)

2cc5aff

ditman mentioned this pull request Jul 17, 2024

[ci][web] Remove CHANNEL override in drive_examples_command. flutter/flutter#151869

Closed

reidbaker mentioned this pull request Jul 25, 2024

[many] Ignore NewerVersionAvailable in android lint #7218

Merged

11 tasks

Conversation

mdebbar commented Jun 6, 2024 • edited by ditman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Pre-launch Checklist

Uh oh!

ditman commented Jun 11, 2024

Uh oh!

ditman commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman commented Jun 12, 2024

Uh oh!

mdebbar commented Jun 12, 2024

Uh oh!

ditman commented Jun 25, 2024

Uh oh!

ditman commented Jul 9, 2024

Uh oh!

ditman commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman commented Jul 9, 2024

Uh oh!

ditman commented Jul 10, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mdebbar commented Jun 6, 2024 •

edited by ditman

Loading

ditman commented Jun 11, 2024 •

edited

Loading

ditman commented Jun 11, 2024 •

edited

Loading

ditman commented Jul 9, 2024 •

edited

Loading