[CI] Bump clang version to 18.1.8, was 15.0.0#7271
Closed
Rexios80 wants to merge 4 commits intoflutter:mainfrom
Closed
[CI] Bump clang version to 18.1.8, was 15.0.0#7271Rexios80 wants to merge 4 commits intoflutter:mainfrom
18.1.8, was 15.0.0#7271Rexios80 wants to merge 4 commits intoflutter:mainfrom
Conversation
11 tasks
Member
Author
|
Of course it wasn't that easy |
Member
Author
|
Welp that version doesn't seem to have the formatter changes |
Member
Author
|
Here are the possible paths I see from here:
|
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
This repo uses clang 15 to format files. Newer versions of clang format code differently. This PR adds a note to the tool README about this and adds sample instructions for how to install clang 15 on macOS. We might want to add instructions for other platforms. Fixes flutter/flutter#152651 Additional context - #7267 - #7271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of
clang-formatare generating different output than what is in the repositoryFixes flutter/flutter#152651
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.