[flutter_adaptive_scaffold] Adds additional slot animation parameters#7411
Merged
auto-submit[bot] merged 6 commits intoflutter:mainfrom Sep 13, 2024
Merged
[flutter_adaptive_scaffold] Adds additional slot animation parameters#7411auto-submit[bot] merged 6 commits intoflutter:mainfrom
auto-submit[bot] merged 6 commits intoflutter:mainfrom
Conversation
martijn00
commented
Aug 14, 2024
martijn00
force-pushed
the
animations_work
branch
2 times, most recently
from
a3445fb to
35e46ea
Compare
Contributor
Author
|
@jamiewest can you pitch on how the out animation is supposed to work? |
martijn00
force-pushed
the
animations_work
branch
2 times, most recently
from
34e9b88 to
af460bb
Compare
martijn00
force-pushed
the
animations_work
branch
2 times, most recently
from
872133c to
07ca445
Compare
Contributor
Author
|
@Renzo-Olivares can you check this? |
gspencergoog
approved these changes
Sep 4, 2024
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Please add a description to the PR.
Contributor
Author
|
@gspencergoog done. |
martijn00
force-pushed
the
animations_work
branch
from
64594f7 to
16136d8
Compare
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
This LGTM but would it be considered a breaking change since duration is being removed?
martijn00
force-pushed
the
animations_work
branch
from
16136d8 to
f1a3e06
Compare
Contributor
Author
|
@Renzo-Olivares I've updated the version number and changelog. |
Renzo-Olivares
approved these changes
Sep 6, 2024
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, but deferring to @gspencergoog regarding removing duration being a breaking change. If it is then it should be stated in the changelog.
martijn00
force-pushed
the
animations_work
branch
from
e3c7251 to
7004764
Compare
martijn00
force-pushed
the
animations_work
branch
from
dcaab41 to
3312839
Compare
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2024
flutter/packages@330581f...df88c81 2024-09-14 [email protected] [webview_flutter] Improve flaky scroll tests (flutter/packages#7621) 2024-09-13 [email protected] Bump deps (flutter/packages#7357) 2024-09-13 [email protected] [flutter_adaptive_scaffold] Use improved MediaQuery methods (flutter/packages#7565) 2024-09-13 [email protected] [many] Update example android apps to target SDK level 34. (flutter/packages#7587) 2024-09-13 [email protected] [pigeon] adds support for non nullable types in collections (flutter/packages#7547) 2024-09-13 [email protected] [flutter_adaptive_scaffold] Adds additional slot animation parameters (flutter/packages#7411) 2024-09-13 [email protected] Roll Flutter from 303f222 to 2d30fe4 (21 revisions) (flutter/packages#7646) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slots can currently be animated in and out of view, but there is not an ability to change the duration or curves of these animations. This PR adds additional parameters that are passed to the underlying AnimatedSwitcher when switching slots in and out of view.
List which issues are fixed by this PR. You must list at least one issue.
#6957
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.