Add support for passing query parameters into benchmark URIs#7632
Closed
kenzieschmoll wants to merge 3 commits intoflutter:mainfrom
Closed
Add support for passing query parameters into benchmark URIs#7632kenzieschmoll wants to merge 3 commits intoflutter:mainfrom
kenzieschmoll wants to merge 3 commits intoflutter:mainfrom
Conversation
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…7640) A breaking change to this package will follow that changes the structure of setting the initial path for the benchmark run. This was originally done in #7632, which was closed because there were more changes needed to get the tests to pass. This cleanup is part of that work. This PR - moves the benchmark clients to `test_app/benchmark` following pub package guidance for naming conventions - regenerates the test_app web assets using `flutter create` to ensure the web configuration is up to date - adds more structure to the benchmark test_infra setup to provide a more thorough example of what a user of this package might need to do. I followed the structure that is used in DevTools benchmark tests.
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
This will unblock flutter/devtools#8320. This is a follow up to the initial attempt here: #7632
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will unblock flutter/devtools#8320