Background/resuming video_player on Android sends one initialized event#7722
Merged
auto-submit[bot] merged 9 commits intomainfrom Oct 2, 2024
Merged
Background/resuming video_player on Android sends one initialized event#7722auto-submit[bot] merged 9 commits intomainfrom
video_player on Android sends one initialized event#7722auto-submit[bot] merged 9 commits intomainfrom
Conversation
gmackall
approved these changes
Sep 30, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
I'm not super knowledgable about this plugin, but the change lgtm!
tarrinneal
approved these changes
Sep 30, 2024
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
looks good. One "nit" which I don't really care if you change, just curious what your thoughts about it are :)
| this(exoPlayer, events, false); | ||
| } | ||
|
|
||
| ExoPlayerEventListener(ExoPlayer exoPlayer, VideoPlayerCallbacks events, boolean wasInitialized) { |
Contributor
There was a problem hiding this comment.
Maybe there is a design guide somewhere that disagrees, but doesn't was imply in the past and (usually) no longer? is is not more appropriate? Not a huge deal either way.
Contributor
Author
There was a problem hiding this comment.
Yeah I think this was a poor word choice on my part, I'd be happy to rename this isInitialized or even initialized for consistency. Let me do that before merging.
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 2, 2024
flutter/packages@ebcc4f0...7c97c88 2024-10-02 [email protected] [file_selector] Convert Linux to Pigeon (flutter/packages#7770) 2024-10-02 [email protected] Background/resuming `video_player` on Android sends one `initialized` event (flutter/packages#7722) 2024-10-02 [email protected] [quick_actions_android] Update instructions for using a launcher activity with more breadcrumbs (flutter/packages#7716) 2024-10-01 [email protected] Add flutter frame timings to benchmark metrics (flutter/packages#7759) 2024-10-01 [email protected] [local_auth] Update Pigeon in iOS and Android (flutter/packages#7724) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#154602.
I also added small clarifications to the error in
video_player(an assertion/error that are better than aCompleter.completedefault error) and updated the documentation invideo_player_platform(it might have been obvious, but it definitely is now).