Convert use of mini_player in the video_player_android test to AndroidVideoPlayer.#7847
Convert use of mini_player in the video_player_android test to AndroidVideoPlayer.#7847auto-submit[bot] merged 3 commits intomainfrom
mini_player in the video_player_android test to AndroidVideoPlayer.#7847Conversation
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
Looks good just a question about a removed test.
| asset: _videoAssetKey, | ||
| )))!; | ||
|
|
||
| testWidgets('can be paused', (WidgetTester tester) async { |
There was a problem hiding this comment.
Should we add back a test for pausing like this one that was removed?
There was a problem hiding this comment.
F. Yup, that was a booboo - re-added. Thanks for calling this out! Done.
There was a problem hiding this comment.
Looks like there was an additional call to await tester.pumpAndSettle(_playDuration) after pause was called in the original test. Maybe that explains the slight difference in player.getPosition(textureId) and pausedDuration causing the test failure?
There was a problem hiding this comment.
Hmm, let's try it :)
|
Thanks @camsim99! PTAL again |
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
LGTM but there's a test failure. Left a comment on maybe why
| asset: _videoAssetKey, | ||
| )))!; | ||
|
|
||
| testWidgets('can be paused', (WidgetTester tester) async { |
There was a problem hiding this comment.
Looks like there was an additional call to await tester.pumpAndSettle(_playDuration) after pause was called in the original test. Maybe that explains the slight difference in player.getPosition(textureId) and pausedDuration causing the test failure?
matanlurey
added
the
autosubmit
…st to `AndroidVideoPlayer`. (flutter/packages#7847)
flutter/packages@bf751e6...a35f02d 2024-10-15 [email protected] Convert use of `mini_player` in the `video_player_android` test to `AndroidVideoPlayer`. (flutter/packages#7847) 2024-10-15 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `UniversalAdId` (flutter/packages#7833) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@bf751e6...a35f02d 2024-10-15 [email protected] Convert use of `mini_player` in the `video_player_android` test to `AndroidVideoPlayer`. (flutter/packages#7847) 2024-10-15 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `UniversalAdId` (flutter/packages#7833) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Closes flutter/flutter#156424.
Also improved an error message that came up as a result.