Remove no_adjacent_strings_in_list from enabled lint rules.#7878
Remove no_adjacent_strings_in_list from enabled lint rules.#7878auto-submit[bot] merged 5 commits intomainfrom
no_adjacent_strings_in_list from enabled lint rules.#7878Conversation
|
We should comment this out with an explanation, as with most other lints we don't use use (see the rest of the file), rather than removing it. It's unfortunate that we're having to turn off a useful warning before we get the formatter change that would make the mistake the warning would catch obvious though. |
|
I'll convert to draft for a bit. |
stuartmorgan-g
added
waiting for stable update
If we are waiting for the new formatter first, this will need to be Draft until all of our packages require Dart 3.7, right? |
|
Sure. |
|
(triage): Talked to @srawlins and he says this is still on his radar. |
|
Still on my radar. Waiting for minimum package versions to be >= 3.7.0. |
Is this condition now satisfied? :) |
|
Nope, the first package I checked is still 3.6.0. https://github.com/flutter/packages/blob/main/packages/animations/pubspec.yaml |
|
The only automatic roll-forward of min SDK versions is that after each stable we update any package that supports a version of Flutter/Dart older than the N-2 stable Flutter version to require N-2 (since we don't run analysis in CI of anything older than N-2, so wouldn't find breakage). So in the normal course of business, this would be landable after the next Flutter |
|
Everything in the repo is now using the new formatter (except for the repo tooling, but that's fine), so we can land this now. |
This still needs to be addressed, then this can land. |
|
Greetings from stale PR triage! 👋 |
|
Yes I'll try to get back to this. |
|
OK this is ready for review. |
stuartmorgan-g
added
the
autosubmit
flutter/packages@148dcd2...8cb4903 2025-12-02 [email protected] Remove `no_adjacent_strings_in_list` from enabled lint rules. (flutter/packages#7878) 2025-12-02 [email protected] Roll Flutter from 05d6005 to 5545bb3 (28 revisions) (flutter/packages#10551) 2025-12-02 [email protected] [two_dimensional_scrollables] Update test for deprecation (flutter/packages#10525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#179407) flutter/packages@148dcd2...8cb4903 2025-12-02 [email protected] Remove `no_adjacent_strings_in_list` from enabled lint rules. (flutter/packages#7878) 2025-12-02 [email protected] Roll Flutter from 05d6005 to 5545bb3 (28 revisions) (flutter/packages#10551) 2025-12-02 [email protected] [two_dimensional_scrollables] Update test for deprecation (flutter/packages#10525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#7878) `no_adjacent_strings_in_list` conflicts with another rule, `prefer_adjacent_string_concatenation`. I suggest removing the former. See dart-lang/sdk#59041 `prefer_adjacent_string_concatenation` is a style-oriented rule, but it is in the package:lints recommended set. So... it is recommended. `no_adjacent_strings_in_list` is an error-preventing lint rule, but it's usefulness is waning, as the [new style of the Dart formatter will always split adjacent strings into new lines](dart-lang/sdk#59041). We are marking these two lint rules as incompatible. If the fix in this PR is not desired, there are two other options: * Remove `prefer_adjacent_string_concatenation` from the enabled lint rules. * Insert an `# ignore:` comment in the top-level analysis options file, and an `# ignore: included_file_warning` comment in any files that include the top-level one.
4 participants
no_adjacent_strings_in_listconflicts with another rule,prefer_adjacent_string_concatenation. I suggest removing the former.See dart-lang/sdk#59041
prefer_adjacent_string_concatenationis a style-oriented rule, but it is in the package:lints recommended set. So... it is recommended.no_adjacent_strings_in_listis an error-preventing lint rule, but it's usefulness is waning, as the new style of the Dart formatter will always split adjacent strings into new lines.We are marking these two lint rules as incompatible. If the fix in this PR is not desired, there are two other options:
prefer_adjacent_string_concatenationfrom the enabled lint rules.# ignore:comment in the top-level analysis options file, and an# ignore: included_file_warningcomment in any files that include the top-level one.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.