[go_router_builder] Proposal: add json support, custom string encoder/decoder by NearTox · Pull Request #8665 · flutter/packages

NearTox · 2025-02-20T02:39:19Z

Add initial json support for use in go_router_builder
Adds annotation that enable custom string encoder/decoder, its enable conversion for base64

This allow custom type conversion for parameters, like mentionated in #117261 and #110781

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/go_router/lib/go_router.dart

packages/go_router_builder/test_inputs/bad_json.dart

packages/go_router_builder/test_inputs/json_template.dart

hannah-hyj · 2025-02-24T23:36:45Z

you also need to bump versions in packages/go_router_builder/CHANGELOG.md and packages/go_router_builder/pubspec.yaml

packages/go_router_builder/lib/src/type_helpers.dart

hannah-hyj · 2025-02-24T23:55:27Z

thank you for contributing the PR! This looks good to me over all with some comments

packages/go_router_builder/test_inputs/bad_json.dart

packages/go_router_builder/lib/src/type_helpers.dart

hannah-hyj · 2025-03-17T22:36:12Z

PR looks good to me over all, just left some nit comments :)

NearTox · 2025-03-19T16:29:08Z

I made a rebase in order to take in account latest changes from main branch

chunhtai · 2025-03-21T20:36:32Z

looks like the ci is not happy

NearTox · 2025-03-21T22:30:01Z

I think it’s because the annotations requires the changes that I made in go_router_builder.
When I tested locally was overriding the dependency.
I should add it?

chunhtai · 2025-03-21T22:47:23Z

they will have to be separate into two prs. I think we try to avoid having one pr that bump the two package at once

hannah-hyj · 2025-05-02T22:23:43Z

Hi @NearTox , is this PR still on your radar? this pr has to be separated into 2 PRs for go_router and go_router_builder

separate json_example to independent file add missing examples

chunhtai · 2025-08-19T18:49:52Z

packages/go_router/CHANGELOG.md

 ## 16.1.0

- Adds annotation for go_router_builder that enable custom string encoder/decoder [#110781](https://github.com/flutter/flutter/issues/110781). **Requires go_router_builder >= 3.1.0**.
+- Adds annotation for go_router_builder that enable custom string encoder/decoder [#110781](https://github.com/flutter/flutter/issues/110781). **Requires go_router_builder >= 3.4.0**.


This is unfortunate, can you have a separate pr to update this once this lands?

chunhtai

LGTM, can you separate out the changlog update from go_router?

NearTox · 2025-08-19T19:00:27Z

@chunhtai the changelog for go_router is only for fix the notice, I don't intent to make a new release.
If you think that the update in the notice (for a old release) not matters. I can remove it

muhammadkamel · 2025-08-22T20:18:54Z

@chunhtai

Could you please assign another reviewer? Hannah might be on vacation, and this feature is important for us.

hannah-hyj

LGTM

muhammadkamel · 2025-08-28T17:31:30Z

Hi @chunhtai,
I hope we can merge this PR as soon as possible.

muhammadkamel · 2025-09-02T07:35:22Z

@NearTox
Could you please resolve the conflicts so we can proceed with merging this PR?

auto-submit · 2025-09-16T22:25:23Z

autosubmit label was removed for flutter/packages/8665, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

… encoder/decoder (flutter/packages#8665)

flutter/packages@3413b65...117bf63 2025-09-24 [email protected] [ci] Add update-release-info command suggestion when version check fails (flutter/packages#9834) 2025-09-24 [email protected] Manual roll Flutter from 9ff2767 to 4a04204 (28 revisions) (flutter/packages#10067) 2025-09-24 [email protected] Remove "All right reserved" from all files (flutter/packages#10066) 2025-09-24 [email protected] [google_sign_in] Implement `disconnect` for Android (flutter/packages#9991) 2025-09-24 [email protected] [camera_android] Remove references to third party `googlesamples/mlkit` code (flutter/packages#10056) 2025-09-23 [email protected] [go_router_builder] [in_app_purchase_storekit] Removes redundant arguments from annotations (flutter/packages#9964) 2025-09-23 [email protected] [go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. (flutter/packages#9868) 2025-09-23 [email protected] [go_router_builder] Proposal: add json support, custom string encoder/decoder (flutter/packages#8665) 2025-09-23 [email protected] [go_router] Fix ShellRoutes break iOS swipe back navigation (flutter/packages#9968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

NearTox requested a review from chunhtai as a code owner February 20, 2025 02:39

github-actions bot added p: go_router_builder p: go_router labels Feb 20, 2025

NearTox force-pushed the main branch from 8e7f994 to 093aa3a Compare February 20, 2025 05:47

chunhtai requested review from hannah-hyj and removed request for chunhtai February 20, 2025 23:12

hannah-hyj reviewed Feb 24, 2025

View reviewed changes

packages/go_router_builder/lib/src/type_helpers.dart Outdated Show resolved Hide resolved

github-actions bot removed the p: go_router label Feb 25, 2025

hannah-hyj requested a review from chunhtai February 25, 2025 19:28

hannah-hyj reviewed Feb 25, 2025

View reviewed changes

packages/go_router_builder/test_inputs/bad_json.dart Outdated Show resolved Hide resolved

NearTox changed the title ~~[go_router_builder] Proposal: add json support~~ [go_router_builder] Proposal: add json support, custom string encoder/decoder Feb 26, 2025

github-actions bot added the p: go_router label Feb 26, 2025

chunhtai requested a review from hannah-hyj March 13, 2025 22:08

hannah-hyj reviewed Mar 17, 2025

View reviewed changes

packages/go_router_builder/lib/src/type_helpers.dart Outdated Show resolved Hide resolved

hannah-hyj reviewed Mar 17, 2025

View reviewed changes

packages/go_router_builder/lib/src/type_helpers.dart Outdated Show resolved Hide resolved

hannah-hyj reviewed Mar 17, 2025

View reviewed changes

packages/go_router_builder/lib/src/type_helpers.dart Outdated Show resolved Hide resolved

hannah-hyj reviewed Mar 17, 2025

View reviewed changes

packages/go_router_builder/lib/src/type_helpers.dart Outdated Show resolved Hide resolved

NearTox force-pushed the main branch from dcb6a19 to 8479cc4 Compare March 19, 2025 16:27

NearTox force-pushed the main branch from 2d48aeb to d38e1e4 Compare March 19, 2025 17:21

hannah-hyj self-requested a review March 24, 2025 22:48

[go_router_builder] add initial json support #110781

0a9a623

separate json_example to independent file add missing examples

chunhtai reviewed Aug 19, 2025

View reviewed changes

chunhtai approved these changes Aug 19, 2025

View reviewed changes

NearTox force-pushed the main branch from 0b7b2a3 to 3c81b59 Compare August 22, 2025 19:37

github-actions bot removed the p: go_router label Aug 22, 2025

hannah-hyj approved these changes Aug 22, 2025

View reviewed changes

chunhtai added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Aug 26, 2025

NearTox force-pushed the main branch from 3c81b59 to a51ef48 Compare September 2, 2025 16:01

github-actions bot added the p: go_router label Sep 2, 2025

NearTox force-pushed the main branch from a51ef48 to 1930fbb Compare September 5, 2025 18:19

github-actions bot removed the p: go_router label Sep 5, 2025

NearTox force-pushed the main branch from 1930fbb to e10f7c3 Compare September 5, 2025 19:07

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2025

NearTox force-pushed the main branch 2 times, most recently from ce1ecb6 to 1dea932 Compare September 22, 2025 22:24

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot merged commit 51df718 into flutter:main Sep 23, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2025

51df718 [go_router_builder] Proposal: add json support, custom string…

106930f

… encoder/decoder (flutter/packages#8665)

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Packages from 3413b65fdde1 to 2fe85dd0f730 (8 revisions) flutter/flutter#175933

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2025

51df718 [go_router_builder] Proposal: add json support, custom string…

0b8c53f

… encoder/decoder (flutter/packages#8665)

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Packages from 3413b65fdde1 to 117bf639ec3a (9 revisions) flutter/flutter#175935

Merged

Conversation

NearTox commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hannah-hyj commented Feb 24, 2025

Uh oh!

Uh oh!

hannah-hyj commented Feb 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hannah-hyj commented Mar 17, 2025

Uh oh!

NearTox commented Mar 19, 2025

Uh oh!

chunhtai commented Mar 21, 2025

Uh oh!

NearTox commented Mar 21, 2025

Uh oh!

chunhtai commented Mar 21, 2025

Uh oh!

hannah-hyj commented May 2, 2025

Uh oh!

chunhtai Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

NearTox commented Aug 19, 2025

Uh oh!

muhammadkamel commented Aug 22, 2025

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

muhammadkamel commented Aug 28, 2025

Uh oh!

muhammadkamel commented Sep 2, 2025

Uh oh!

auto-submit bot commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NearTox commented Feb 20, 2025 •

edited

Loading