[android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using `ImageReader` Impeller backend by camsim99 · Pull Request #9233 · flutter/packages

camsim99 · 2025-05-09T16:43:33Z

Fixes the incorrect camera mirroring when the front camera is used on devices that use the ImageReader Impeller backend. TLDR: for relevant rotated preview implementation, when the front camera is used, mirror the camera preview across the y-axis when the device is in a portrait orientation or across the x-axis when the device is in a landscape orientation.

Fixes flutter/flutter#156974.

cc @jesswrd, co-author of this PR

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

camsim99

These look great, thank you! Just added some suggestions for clarity in case someone has to revisit this later :)

packages/camera/camera_android_camerax/test/preview_rotation_test.dart

This reverts commit e2fba01.

camsim99

LGTM! Just found an extra space

packages/camera/camera_android_camerax/CHANGELOG.md

camsim99 · 2025-06-12T14:44:19Z

@jesswrd and I worked on this PR together, so we'll need another reviewer to land this PR!

Co-authored-by: Camille Simon <[email protected]>

reidbaker · 2025-06-12T14:46:28Z

packages/camera/camera_android_camerax/lib/src/image_reader_rotated_preview.dart

+          // If the camera is front facing, mirror the camera preview
+          // according to the current device orientation.
+          Widget cameraPreview = widget.child;
+          if (widget.facingSign == 1) {


Why is == 1 the correct comparison here?

Ah because facingSign maps to the sign in https://developer.android.com/media/camera/camera2/camera-preview#orientation_calculation, which is 1 for front cameras, -1 for back facing cameras. I'll add a comment to the code!

… camx_mirror_2

…ront cameras on devices using `ImageReader` Impeller backend (flutter/packages#9233)

flutter/packages@6d3aaf4...c5ab57a 2025-06-13 [email protected] [flutter_svg] feat: Expose the renderStrategy property in SvgPicture (flutter/packages#9373) 2025-06-12 [email protected] [go_router] Add routing functions to GoRouteData (flutter/packages#9277) 2025-06-12 [email protected] [various] Update example apps to Swift (flutter/packages#9347) 2025-06-12 [email protected] Roll Flutter from 824868f to f79452e (94 revisions) (flutter/packages#9419) 2025-06-12 [email protected] [android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using `ImageReader` Impeller backend (flutter/packages#9233) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@jesswrd

…eras on devices using `ImageReader` Impeller backend (flutter#9233) Fixes the incorrect camera mirroring when the front camera is used on devices that use the `ImageReader` Impeller backend. TLDR: for relevant rotated preview implementation, when the front camera is used, mirror the camera preview across the y-axis when the device is in a portrait orientation or across the x-axis when the device is in a landscape orientation. Fixes flutter/flutter#156974. cc @jesswrd, co-author of this PR ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

flutter/packages@6d3aaf4...c5ab57a 2025-06-13 [email protected] [flutter_svg] feat: Expose the renderStrategy property in SvgPicture (flutter/packages#9373) 2025-06-12 [email protected] [go_router] Add routing functions to GoRouteData (flutter/packages#9277) 2025-06-12 [email protected] [various] Update example apps to Swift (flutter/packages#9347) 2025-06-12 [email protected] Roll Flutter from 824868f to f79452e (94 revisions) (flutter/packages#9419) 2025-06-12 [email protected] [android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using `ImageReader` Impeller backend (flutter/packages#9233) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@jesswrd

…eras on devices using `ImageReader` Impeller backend (flutter#9233) Fixes the incorrect camera mirroring when the front camera is used on devices that use the `ImageReader` Impeller backend. TLDR: for relevant rotated preview implementation, when the front camera is used, mirror the camera preview across the y-axis when the device is in a portrait orientation or across the x-axis when the device is in a landscape orientation. Fixes flutter/flutter#156974. cc @jesswrd, co-author of this PR ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

camsim99 added 2 commits May 8, 2025 13:47

mirror camera

7b3809a

fix tests + bump version

1351c20

github-actions bot added the p: camera label May 9, 2025

jesswrd marked this pull request as draft May 9, 2025 19:36

jesswrd changed the title ~~[android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using ImageReader Impeller backend~~ [WIP] [android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using ImageReader Impeller backend May 9, 2025

added mirroring tests

ceb9865

jesswrd changed the title ~~[WIP] [android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using ImageReader Impeller backend~~ [android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using ImageReader Impeller backend Jun 2, 2025

jesswrd added 2 commits June 2, 2025 14:46

resolved conflicts

50897b2

updated changelog

fe4ffb3

camsim99 marked this pull request as ready for review June 2, 2025 22:36

formatted files

bdf32a7

camsim99 commented Jun 3, 2025

View reviewed changes

packages/camera/camera_android_camerax/test/preview_rotation_test.dart Outdated Show resolved Hide resolved

packages/camera/camera_android_camerax/test/preview_rotation_test.dart Outdated Show resolved Hide resolved

jesswrd added 6 commits June 11, 2025 14:10

added helper function. has to check entire matrix

e2fba01

Revert "added helper function. has to check entire matrix"

c4b1fd6

This reverts commit e2fba01.

added helper function. has to check entire matrix (take 2)

0139263

Merge branch 'main' into camx_mirror_2

a0c9bc9

formatted tests

ad702cc

updated changelog

de19674

camsim99 commented Jun 12, 2025

View reviewed changes

packages/camera/camera_android_camerax/CHANGELOG.md Outdated Show resolved Hide resolved

camsim99 requested a review from a team June 12, 2025 14:43

Update packages/camera/camera_android_camerax/CHANGELOG.md

0061ab0

Co-authored-by: Camille Simon <[email protected]>

reidbaker reviewed Jun 12, 2025

View reviewed changes

reidbaker approved these changes Jun 12, 2025

View reviewed changes

camsim99 added 2 commits June 12, 2025 07:59

add comment

541f537

Merge remote-tracking branch 'refs/remotes/origin/camx_mirror_2' into…

5fe7d84

… camx_mirror_2

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2025

auto-submit bot merged commit ee79db6 into flutter:main Jun 12, 2025
78 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2025

ee79db6 [android_camera_camerax] Fix incorrect camera mirroring for f…

1384599

…ront cameras on devices using `ImageReader` Impeller backend (flutter/packages#9233)

engine-flutter-autoroll mentioned this pull request Jun 13, 2025

Roll Packages from 6d3aaf4b5523 to c5ab57a54105 (5 revisions) flutter/flutter#170587

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2025

ee79db6 [android_camera_camerax] Fix incorrect camera mirroring for f…

be7bb72

…ront cameras on devices using `ImageReader` Impeller backend (flutter/packages#9233)

engine-flutter-autoroll mentioned this pull request Jun 13, 2025

Roll Packages from 6d3aaf4b5523 to c5ab57a54105 (5 revisions) flutter/flutter#170600

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using `ImageReader` Impeller backend#9233

[android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using `ImageReader` Impeller backend#9233
auto-submit[bot] merged 15 commits intoflutter:mainfrom
camsim99:camx_mirror_2

camsim99 commented May 9, 2025 •

edited

Loading

Uh oh!

camsim99 left a comment

Uh oh!

Uh oh!

Uh oh!

camsim99 left a comment

Uh oh!

Uh oh!

camsim99 commented Jun 12, 2025

Uh oh!

reidbaker Jun 12, 2025

Uh oh!

camsim99 Jun 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

camsim99 commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

camsim99 commented Jun 12, 2025

Uh oh!

reidbaker Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camsim99 commented May 9, 2025 •

edited

Loading