Merged
Conversation
Merged
8 tasks
MitchellGoodwin
approved these changes
Feb 27, 2023
Contributor
MitchellGoodwin
left a comment
There was a problem hiding this comment.
LGTM. This is awesome! Thank you for very much for putting this together.
Contributor
|
@ivirtex there was some scorecard failures on the merge that you may have been notified about, but I think those can be ignored. Improving the routes in Cupertino is a big goal of mine, so I'm very excited to have this. Realistically, it will be about a month before I can work directly on the routes, but if you were planning on improving this tool or other work in this area, please don't hesitate to tag me or reach out on discord for discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a tool to compare page transitions between Flutter and native iOS.
Best effects are achieved when testing on a real device with a ProMotion display (simulators and non ProMotion devices also work but expect loss of precision on the graph due to twice as long frame times).
Features:
Things to consider:
Fixes flutter/flutter#22862
Pre-launch Checklist
///).