This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Supress strong_mode_implicit_dynamic_method for invokeMethod calls.#1065
Merged
amirh merged 1 commit intoflutter:masterfrom Jan 12, 2019
Merged
Supress strong_mode_implicit_dynamic_method for invokeMethod calls.#1065amirh merged 1 commit intoflutter:masterfrom
strong_mode_implicit_dynamic_method for invokeMethod calls.#1065amirh merged 1 commit intoflutter:masterfrom
Conversation
flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo. We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release. For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code) See: flutter/flutter#26431
gspencergoog
approved these changes
Jan 11, 2019
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
I'm sensing an increase in technical debt here...
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…s. (flutter#1065) flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo. We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release. For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code) See: flutter/flutter#26431
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…od` calls. (flutter#1065)" This reverts commit 8b14bc4.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…s. (flutter#1065) flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo. We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release. For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code) See: flutter/flutter#26431
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
…s. (flutter#1065) flutter/flutter#26303 added a template argument to `invokeMethod`, which triggers the `strong_mode_implicit_dynamic_method` analyzer warning in many call sites in the plugins repo. We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the `invokeMethod` change makes it to the stable release. For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code) See: flutter/flutter#26431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/flutter#26303 added a template argument to
invokeMethod, which triggers thestrong_mode_implicit_dynamic_methodanalyzer warning in many call sites in the plugins repo.We should add the type parameter to all these call sites, but we can only do that after bumping the Flutter dependency constraint which we will only do once the
invokeMethodchange makes it to the stable release.For now we're suppressing the warning in all call sites (we're not disabling the lint wholesale as we still want it for the rest of the code)
See: flutter/flutter#26431