This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] Update and comment out the 'set marker icon' sample.#1640
Merged
amirh merged 2 commits intoflutter:masterfrom May 28, 2019
Merged
[google_maps_flutter] Update and comment out the 'set marker icon' sample.#1640amirh merged 2 commits intoflutter:masterfrom
amirh merged 2 commits intoflutter:masterfrom
Conversation
This updates the sample to adapt to the ImageStream listener API changes in flutter/flutter#32936 As we cannot use the new API before it makes it to stable I'm commenting out the sample for now(if we update it now it won't compile on stable, and if we leave it as is it breaks CI on master).
amirh
changed the title
13 tasks
amirh
added a commit
that referenced
this pull request
May 28, 2019
This updates the sample to adapt to the ImageStream listener API changes in flutter/flutter#32936 This is similar to the change we did to Google Maps in #1640, unfortunately in the firebase_ml_vision case where we commented out the sample that used the ImageStream listener API. Unfortunately in the firebase_ml_vision case, there's no point in the sample without the ImageStream listener(you need it to pick an image), so I'm just updating the sample to the new API knowing that it won't compile on stable until the breaking change makes it there.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This updates the sample to adapt to the ImageStream listener API changes in flutter/flutter#32936 This is similar to the change we did to Google Maps in flutter#1640, unfortunately in the firebase_ml_vision case where we commented out the sample that used the ImageStream listener API. Unfortunately in the firebase_ml_vision case, there's no point in the sample without the ImageStream listener(you need it to pick an image), so I'm just updating the sample to the new API knowing that it won't compile on stable until the breaking change makes it there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the sample to adapt to the ImageStream listener API changes
in flutter/flutter#32936
As we cannot use the new API before it makes it to stable I'm commenting
out the sample for now(if we update it now it won't compile on stable,
and if we leave it as is it breaks CI on master).
Related Issues
Tracking issue: flutter/flutter#33438
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?