This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Readme updates#1798
Merged
collinjackson merged 4 commits intoflutter:masterfrom Jul 8, 2019
Merged
Conversation
CHANGELOG * Remove explicit typing in `_subscription` callback * Remove `const` modifier for `_kIds` list * Fix not found ids check typos * Migrate loop iterator from `:` to `in`
moritzmorgenroth
changed the title
cyanglaz
added
documentation
submit queue
Fix typo
Contributor
|
LGTM as well, I fixed one more typo and will go ahead and merge this as it seems like a low-risk documentation change. |
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
* Documentation updates CHANGELOG * Remove explicit typing in `_subscription` callback * Remove `const` modifier for `_kIds` list * Fix not found ids check typos * Migrate loop iterator from `:` to `in` * Fix typo from flutter#1798
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* Added unit test for the onAuthStateChanged stream (from JS). * Migrate tests from jsify to package:js * Update version and CHANGELOG Fixes firebase/flutterfire#1685
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the following fixes to the code samples in the documentation, as they contained some syntax errors / errors:
_subscriptioncallbackconstmodifier for_kIdslist:toinDescription
In noticed a few glitches in the docs for the
in_app_purchaseplugin when integrating with an up-to-date flutter app.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?