Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Recommend 4.3.0 version of google-services in READMEs/examples#1885

Merged
collinjackson merged 5 commits intoflutter:masterfrom
collinjackson:google_services_4_3
Jul 22, 2019
Merged

Recommend 4.3.0 version of google-services in READMEs/examples#1885
collinjackson merged 5 commits intoflutter:masterfrom
collinjackson:google_services_4_3

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Jul 20, 2019 •
edited
Loading

Per discussion flutter/flutter#28770 (comment)

We can prevent these deprecation warnings by updating to a newer version of google-services gradle plugin.

flutter run                                                                                                     11:32:05
Launching lib/main.dart on Pixel 2 in debug mode...
Initializing gradle...                                              1.9s
Resolving dependencies...                                           5.2s
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)
Note: /Users/deg/.pub-cache/hosted/pub.dartlang.org/firebase_core-0.4.0+6/android/src/main/java/io/flutter/plugins/firebase/core/FirebaseCorePlugin.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.                      
Running Gradle task 'assembleDebug'...                                  
Running Gradle task 'assembleDebug'... Done                        45.0s
Built build/app/outputs/apk/debug/app-debug.apk.
...

This change will cause warnings to be emitted to the console the first time building after upgrading an app's google-services.

ERROR: [TAG] Failed to resolve variable '${junit.version}'              
ERROR: [TAG] Failed to resolve variable '${animal.sniffer.version}'

Subsequent builds will not have the error.

Fixes fluttere/flutter#28982

kroikie
kroikie approved these changes Jul 20, 2019
View reviewed changes
Copy link
Contributor

@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jul 20, 2019
Closed
Closed
@collinjackson
Copy link
Contributor Author

collinjackson commented Jul 22, 2019

Landing this on red because the analyzer failures are a known issue (see #1882) and iOS build timeouts cannot be caused by Android-only changes.

@collinjackson collinjackson merged commit 88992d9 into flutter:master Jul 22, 2019
@collinjackson collinjackson deleted the google_services_4_3 branch July 22, 2019 15:28
@repentsinner
Copy link

repentsinner commented Jul 22, 2019

Thanks for this @collinjackson!

Is this type of thing something that flutter doctor should be checking for?

Coming up to speed with Flutter feels like I spend the same amount of effort hunting down Magic Boilerplate issues as I do figuring out what's wrong with my own code.

mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
@collinjackson @mithun-mondal
Recommend 4.3.0 version of google-services in READMEs/examples (flutt…
6326dc9 
…er#1885)
cremor
cremor reviewed Aug 23, 2019
View reviewed changes
packages/firebase_messaging/example/pubspec.yaml
description: Demonstrates how to use the firebase_messaging plugin.

dependencies:
firebase_analytics: any
Copy link

@cremor cremor Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@collinjackson Why was this added? Is it recommended to also depend on firebase_analytics when you use firebase_messaging?

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@collinjackson
Recommend 4.3.0 version of google-services in READMEs/examples (flutt…
e99a1a4 
…er#1885)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bkonyi bkonyi Awaiting requested review from bkonyi

@amirh amirh Awaiting requested review from amirh

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

2 more reviewers

@cremor cremor cremor left review comments

@kroikie kroikie kroikie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@collinjackson @repentsinner @cremor @kroikie @googlebot