This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter]Google maps plugin memory leak fix#1892
Merged
amirh merged 6 commits intoflutter:masterfrom Jul 26, 2019
juliocbcotta:google_maps_plugin_fix
Merged
[google_maps_flutter]Google maps plugin memory leak fix#1892amirh merged 6 commits intoflutter:masterfrom juliocbcotta:google_maps_plugin_fix
amirh merged 6 commits intoflutter:masterfrom
juliocbcotta:google_maps_plugin_fix
Conversation
amirh
suggested changes
Jul 23, 2019
Contributor
amirh
left a comment
There was a problem hiding this comment.
Thanks!
looks good overall, please update the version number
Contributor
|
Will land on green |
otopba
approved these changes
Jul 26, 2019
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to solve a memory leak in Google maps where the number of
ActivityLifecycleCallbackswould increase every time the FlutterActivity is created, as the previous reference was not removed.Related Issues
flutter/flutter#36520
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?