This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Allow underscores anywhere for Javascript Channel name#1996
Merged
amirh merged 3 commits intoflutter:masterfrom Sep 12, 2019
Merged
[webview_flutter] Allow underscores anywhere for Javascript Channel name#1996amirh merged 3 commits intoflutter:masterfrom
amirh merged 3 commits intoflutter:masterfrom
Conversation
13 tasks
amirh
reviewed
Aug 21, 2019
amirh
approved these changes
Sep 11, 2019
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
LGTM
Will land on green, thanks!
13 tasks
Member
Author
|
Seems CI broken is not related. |
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
…ame (flutter#1996) * [webview_flutter] Allow underscores anywhere for Javascript Channel name
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…ame (flutter#1996) * [webview_flutter] Allow underscores anywhere for Javascript Channel name
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow underscores anywhere for Javascript Channel name
Related Issues
flutter/flutter#35011
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?