This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Re-land testing of plugins on stable#2203
Merged
collinjackson merged 12 commits intoflutter:masterfrom Oct 17, 2019
Merged
Conversation
amirh
reviewed
Oct 16, 2019
.cirrus.yml
Outdated
| build_script: | ||
| # TODO(jackson): Allow web plugins once supported on stable | ||
| # https://github.com/flutter/flutter/issues/42864 | ||
| - if [ "CHANNEL" -eq "stable" ]; do find . | grep _web$ | xargs rm -rf |
Contributor
There was a problem hiding this comment.
Is the matrix ordering guaranteed?
Contributor
Author
There was a problem hiding this comment.
it's a shard, so it won't run at all on master
collinjackson
force-pushed
the
reland_stable_testing
branch
from
a1e33fd to
1495c74
Compare
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
* Revert "Revert "Enable testing on both master and stable (flutter#2197)"" This reverts commit 1162798. * Suppress testing of web plugins for now * Run all plugins on stable * Ignore deprecation warning in video player plugin
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
* Revert "Revert "Enable testing on both master and stable (flutter#2197)"" This reverts commit 1162798. * Suppress testing of web plugins for now * Run all plugins on stable * Ignore deprecation warning in video player plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web plugins are now suppressed when testing on stable.
Filed flutter/flutter#42864 for the eventual fix
Re-lands #2197 that was reverted in #2199
Fixes flutter/flutter#42810
Fixes flutter/flutter#42377