This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Use package import to import files inside lib/ directory.#2236
Merged
chingjun merged 1 commit intoflutter:masterfrom Oct 25, 2019
Merged
Use package import to import files inside lib/ directory.#2236chingjun merged 1 commit intoflutter:masterfrom
chingjun merged 1 commit intoflutter:masterfrom
Conversation
amirh
reviewed
Oct 25, 2019
|
|
||
| import '../lib/method_channel_url_launcher.dart'; | ||
| import '../lib/url_launcher_platform_interface.dart'; | ||
| import 'package:url_launcher_platform_interface/method_channel_url_launcher.dart'; |
Contributor
There was a problem hiding this comment.
interesting, Android Studio kept replacing the package path with '../' when I was editing this file.
amirh
reviewed
Oct 25, 2019
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
Can you update the changelog and bump the patch version as well?
chingjun
force-pushed
the
package_import
branch
from
869f739 to
0eda3dd
Compare
Contributor
Author
|
Done, PTAL. Thanks. |
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is causing issues intenally.
This is also the recommended way in Dart guidelines: https://dart.dev/guides/libraries/create-library-packages#importing-library-files