Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] : Flutter's video plugin can cause crashes after a closing a flutter vi…#2480

Merged
stuartmorgan-g merged 6 commits intoflutter:masterfrom
shihchanghsiungsonos:master-local
Feb 9, 2021
Merged

[video_player] : Flutter's video plugin can cause crashes after a closing a flutter vi…#2480
stuartmorgan-g merged 6 commits intoflutter:masterfrom
shihchanghsiungsonos:master-local

Conversation

@shihchanghsiungsonos
Copy link
Contributor

@shihchanghsiungsonos shihchanghsiungsonos commented Jan 22, 2020

…ew on simulator model iPhone X or higher

Description

The latest video player plugin changes weren't actually overriding the correct method signature.
Updated the override and verified that we are now getting disposed, and we don't crash on iPhone X running iOS 12.

Related Issues

#2124

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@shihchanghsiungsonos shihchanghsiungsonos mentioned this pull request Jan 22, 2020
Merged
13 tasks
@dannyvalentesonos
Copy link

dannyvalentesonos commented Feb 24, 2020

@otopba @cyanglaz Is there a reason this hasn't been merged yet?

@otopba
Copy link
Contributor

otopba commented Feb 25, 2020

@dannyvalentesonos I'm not a part of the Google team. So, I think you can merge last master changes and just wait =(

@shihchanghsiungsonos
Copy link
Contributor Author

shihchanghsiungsonos commented Mar 6, 2020

Also check and see if we can have this on merged? Thanks!

@dannyvalentesonos
Copy link

dannyvalentesonos commented Oct 23, 2020

@cyanglaz Can we consider this change please? The onTextureUnregistered signature was not correct and therefore wasn't getting called. The temporary disposal code in handleMethodCall can also be removed.

@Salakar
Copy link
Member

Salakar commented Jan 14, 2021

Can confirm this is PR is valid; the correct signature is - (void)onTextureUnregistered:(NSObject<FlutterTexture>*)texture; as defined in FlutterTexture.h: https://github.com/flutter/engine/blob/be8839f59e1c2390815f5197dcb5be95018df335/shell/platform/darwin/common/framework/Headers/FlutterTexture.h#L31

russellwheatley
russellwheatley approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 46207ea into flutter:master Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

4 more reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@otopba otopba otopba approved these changes

@Salakar Salakar Salakar approved these changes

@russellwheatley russellwheatley russellwheatley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: video_player

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shihchanghsiungsonos @dannyvalentesonos @otopba @Salakar @stuartmorgan-g @russellwheatley @googlebot