This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[e2e] Test multiple failure behavior#2514
Merged
collinjackson merged 2 commits intoflutter:masterfrom Feb 11, 2020
Merged
Conversation
collinjackson
changed the title
gaaclarke
approved these changes
Feb 11, 2020
nturgut
reviewed
Feb 11, 2020
| expect( | ||
| result, | ||
| 'failure', | ||
| skip: true, // https://github.com/flutter/flutter/issues/48601 |
Contributor
There was a problem hiding this comment.
question: why is skip used?
Member
There was a problem hiding this comment.
i'm about to issue a fix for it is the idea.
sanekyy
pushed a commit
to sanekyy/plugins
that referenced
this pull request
Feb 18, 2020
* driver test for failure behavior
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
* driver test for failure behavior
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* driver test for failure behavior
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a skipped integration test for flutter/flutter#48601.
Will be fixed by #2465
Note: Right now the plugins CI only runs e2e driver tests on iOS. However, this should be sufficient to exercise the fix for flutter/flutter#48601.
Related Issues
flutter/flutter#48601