This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Improved documentation of the headers parameter.#3097
Merged
amirh merged 3 commits intoflutter:masterfrom Oct 15, 2020
Merged
[url_launcher] Improved documentation of the headers parameter.#3097amirh merged 3 commits intoflutter:masterfrom
headers parameter.#3097amirh merged 3 commits intoflutter:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
mvanbeusekom
force-pushed
the
issue#61332
branch
from
501e509 to
a25dbba
Compare
amirh
reviewed
Oct 14, 2020
| /// [enableDomStorage] is an Android only setting. If true, WebView enable | ||
| /// DOM storage. | ||
| /// [headers] is an Android only setting that adds headers to the WebView. | ||
| /// Adding headers without using a WebView is not fully supported. |
Contributor
There was a problem hiding this comment.
I think that a reader of this comment is looking to understand whether and under what circumstances he can use this. Maybe something like:
When not using a WebView, the header information is passed to the browser, some Android browsers do not support the [Browser.EXTRA_HEADERS](https://developer.android.com/reference/android/provider/Browser#EXTRA_HEADERS) intent extra and will lose the header information.
Sempakonka
force-pushed
the
issue#61332
branch
from
a25dbba to
a432894
Compare
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…utter#3097) Added a clear documentation of the fact that the headers parameter at the launch method is not fully supported by all external browsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a clear documentation of the fact that the
headersparameter at thelaunchmethod is not fully supported when using an external browser.Related Issues
Issue 61332.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?