Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Migrate to .ci.yaml#3938

Merged
CaseyHillers merged 2 commits intoflutter:masterfrom
CaseyHillers:star-migration
May 24, 2021
Merged

Migrate to .ci.yaml#3938
CaseyHillers merged 2 commits intoflutter:masterfrom
CaseyHillers:star-migration

Conversation

@CaseyHillers
Copy link

@CaseyHillers CaseyHillers commented May 19, 2021

Issues

flutter/flutter#82303

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label May 19, 2021
@CaseyHillers CaseyHillers mentioned this pull request May 19, 2021
Closed
9 tasks
christopherfujino
christopherfujino approved these changes May 19, 2021
View reviewed changes
Copy link

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@fluttergithubbot
Copy link

fluttergithubbot commented May 21, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build-web+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build-ipas+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@CaseyHillers CaseyHillers added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@fluttergithubbot
Copy link

fluttergithubbot commented May 21, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite build-web+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@CaseyHillers CaseyHillers added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@fluttergithubbot
Copy link

fluttergithubbot commented May 21, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite build-web+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@CaseyHillers CaseyHillers added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 24, 2021
@CaseyHillers
Copy link
Author

CaseyHillers commented May 24, 2021

Submitting as windows timeouts are infra related to certs

@CaseyHillers CaseyHillers merged commit 12c3291 into flutter:master May 24, 2021
@CaseyHillers CaseyHillers deleted the star-migration branch May 24, 2021 18:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2021
@engine-flutter-autoroll
12c3291 Migrate to .ci.yaml (flutter/plugins#3938)
ac2eb58
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented May 24, 2021

In the future, unless there's some reason you can't, please merge in master to pick up fixes instead of landing with failing tests.

fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request May 24, 2021
@engine-flutter-autoroll
12c3291 Migrate to .ci.yaml (flutter/plugins#3938) (#83281)
de23eb7
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 25, 2021
Closed
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@fotiDim
Migrate to .ci.yaml (flutter#3938)
a383dfb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CaseyHillers @fluttergithubbot @stuartmorgan-g @christopherfujino