This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Do not trigger flat device orientation on iOS#4010
Merged
mvanbeusekom merged 1 commit intoflutter:masterfrom Jun 4, 2021
Merged
[camera] Do not trigger flat device orientation on iOS#4010mvanbeusekom merged 1 commit intoflutter:masterfrom
mvanbeusekom merged 1 commit intoflutter:masterfrom
Conversation
07b4f7b to
8200708
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 4, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when an iOS device oriented
UIDeviceOrientationFaceUporUIDeviceOrientationFaceDownthe camera plugin would map this to a default "portrait" orientation. The means when the device is in landscape and is rotated flat, the camera unexpectedly flips to portrait.Video of bug: https://www.youtube.com/watch?v=cZI4M9GCm8E
UIDeviceOrientationFaceUpandUIDeviceOrientationFaceDownto keep the previous portrait or landscape orientation.CameraPluginTestsmodule test with aCameraOrientationTests. Validated this tests fails on master, but passes on this PR.DevelopmentTeambuild settings.Fixes flutter/flutter#83861
Pre-launch Checklist
dart format. See [plugin_tool format])[shared_preferences]///).