Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[quick_actions] Migrate to new analysis options#4548

Merged
stuartmorgan-g merged 2 commits intoflutter:masterfrom
stuartmorgan-g:analysis-quick-actions
Nov 28, 2021
Merged

[quick_actions] Migrate to new analysis options#4548
stuartmorgan-g merged 2 commits intoflutter:masterfrom
stuartmorgan-g:analysis-quick-actions

Conversation

@stuartmorgan-g
Copy link
Contributor

Removes the use of the legacy analysis options, and fixes the resulting analysis issues.

No version change: No changes that should affect behavior or package clients.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit 1e2ffdb into flutter:master Nov 28, 2021
@stuartmorgan-g stuartmorgan-g deleted the analysis-quick-actions branch November 28, 2021 16:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 28, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
Removes the use of the legacy analysis options, and fixes the resulting analysis issues.

No version change: No changes that should affect behavior or package clients.

Part of flutter/flutter#76229
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Removes the use of the legacy analysis options, and fixes the resulting analysis issues.

No version change: No changes that should affect behavior or package clients.

Part of flutter/flutter#76229
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants