Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] WKWebView implementation of loadFlutterAsset method.#4582

Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom
Baseflow:webview_wkwebview_load_asset
Dec 7, 2021
Merged

[webview_flutter] WKWebView implementation of loadFlutterAsset method.#4582
fluttergithubbot merged 4 commits intoflutter:masterfrom
Baseflow:webview_wkwebview_load_asset

Conversation

@mvanbeusekom
Copy link
Contributor

@mvanbeusekom mvanbeusekom commented Dec 6, 2021

WKWebView (iOS) implementation of the loadFlutterAsset method of the platform interface.

Related issue: flutter/flutter#27086

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Dec 6, 2021
@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-ios labels Dec 6, 2021
@mvanbeusekom mvanbeusekom force-pushed the webview_wkwebview_load_asset branch from e4b2dd1 to 9b5ee4a Compare December 6, 2021 17:14
stuartmorgan-g
stuartmorgan-g approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 6, 2021
@fluttergithubbot
Copy link

fluttergithubbot commented Dec 7, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite android-platform_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 7, 2021
@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Dec 7, 2021
@mvanbeusekom mvanbeusekom mentioned this pull request Dec 7, 2021
Merged
11 tasks
@fluttergithubbot fluttergithubbot merged commit 131036d into flutter:master Dec 7, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 7, 2021
@engine-flutter-autoroll
131036d [webview_flutter] WKWebView implementation of loadFlutterAsse…
35564b3 
…t method. (flutter/plugins#4582)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@mvanbeusekom @amantoux
[webview_flutter] WKWebView implementation of loadFlutterAsset method. (
6ec5ea5 
flutter#4582)
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@mvanbeusekom @KyleFin
[webview_flutter] WKWebView implementation of loadFlutterAsset method. (
bbf7a27 
flutter#4582)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: webview_flutter Edits files for a webview_flutter plugin platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvanbeusekom @fluttergithubbot @stuartmorgan-g