This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Remove dependency on flutter.dev and google.com (Android/WKWebView)#4707
Merged
BeMacized merged 1 commit intoflutter:mainfrom Jan 27, 2022
Conversation
github-actions
bot
added
p: webview_flutter
stuartmorgan-g
approved these changes
Jan 27, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I added the same CHANGELOG override comment to the PR description; you'll just need to push some kind of update (e.g., amend the commit to make a trivial change to the commit message, then force push) to get the publishable check to pass.
…r Android and iOS
BeMacized
force-pushed
the
webview/integration_webserver_native
branch
from
dcd43ef to
1850341
Compare
BeMacized
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2022
…kages for Android and iOS (flutter/plugins#4707)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 28, 2022
…kages for Android and iOS (flutter/plugins#4707)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to this one:
It applies the same changes that were made to the integration tests for the app facing package, to the identical integration tests in the webview_flutter_android and webview_flutter_wkwebview packages.
Part of flutter/flutter#95420
No CHANGELOG change: refactoring tests