This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Documentation improvement for file scheme to readme#4711
Merged
fluttergithubbot merged 5 commits intoflutter:mainfrom Feb 10, 2022
Merged
[url_launcher] Documentation improvement for file scheme to readme#4711fluttergithubbot merged 5 commits intoflutter:mainfrom
fluttergithubbot merged 5 commits intoflutter:mainfrom
Conversation
stuartmorgan-g
suggested changes
Feb 8, 2022
stuartmorgan-g
suggested changes
Feb 8, 2022
Contributor
|
@bparrishMines for a quick secondary review. |
stuartmorgan-g
approved these changes
Feb 8, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with two last nits.
| | `mailto:<email address>?subject=<subject>&body=<body>` | `mailto:[email protected]?subject=News&body=New%20plugin` | Create email to <email address> in the default email app | | ||
| | `tel:<phone number>` | `tel:+1-555-010-999` | Make a phone call to <phone number> using the default phone app | | ||
| | `sms:<phone number>` | `sms:5550101234` | Send an SMS message to <phone number> using the default messaging app | | ||
| | `file:<path>` | `file:/home` | Opens file or folder using default app association, supported on desktop platforms | |
Contributor
There was a problem hiding this comment.
Sorry, one more nit 😐 : This should be "Open" instead of "Opens" to match all of the others.
| if (await File(uri.toFilePath()).exists()) { | ||
| if (!await launch(uri.toString())) { | ||
| throw 'Could not launch $uri'; | ||
| } |
Contributor
There was a problem hiding this comment.
And one more: this body is indented 4 instead of 2, making it inconsistent with the inner if's indentation of 2 (and normal Dart practice of indenting 2)
stuartmorgan-g
added
last mile
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for documentation on readme file:
Uriclass documentationFixes flutter/flutter#97422
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.