This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[shared_preferences] Move away from shared method channel implementation in native packages.#4723
Merged
fluttergithubbot merged 12 commits intoflutter:mainfrom Feb 9, 2022
Conversation
stuartmorgan-g
suggested changes
Feb 2, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Just minor things here as well.
packages/shared_preferences/shared_preferences_android/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_macos/lib/shared_preferences_macos.dart
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_linux/test/shared_preferences_linux_test.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_linux/test/shared_preferences_linux_test.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_macos/pubspec.yaml
Outdated
Show resolved
Hide resolved
stuartmorgan-g
suggested changes
Feb 7, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Sorry, I missed a few things.
...ages/shared_preferences/shared_preferences_android/test/shared_preferences_android_test.dart
Outdated
Show resolved
Hide resolved
...ages/shared_preferences/shared_preferences_android/test/shared_preferences_android_test.dart
Outdated
Show resolved
Hide resolved
...ages/shared_preferences/shared_preferences_android/test/shared_preferences_android_test.dart
Outdated
Show resolved
Hide resolved
...ages/shared_preferences/shared_preferences_android/test/shared_preferences_android_test.dart
Show resolved
Hide resolved
...ages/shared_preferences/shared_preferences_android/test/shared_preferences_android_test.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_windows/lib/shared_preferences_windows.dart
Show resolved
Hide resolved
stuartmorgan-g
suggested changes
Feb 8, 2022
| final String key = (methodCall.arguments['key'] as String?)!; | ||
| final Object value = (methodCall.arguments['value'] as Object?)!; | ||
| final String key = methodCall.arguments['key'] as String; | ||
| final Object value = methodCall.arguments['value'] as Object; |
Contributor
There was a problem hiding this comment.
Don't these need !s? I would expect you to get an analyzer warning about using as to convert from nullable to non-nullable.
Contributor
Author
There was a problem hiding this comment.
I wondered the same thing, but as it gave me no warnings I left it out.
packages/shared_preferences/shared_preferences_linux/CHANGELOG.md
Outdated
Show resolved
Hide resolved
stuartmorgan-g
suggested changes
Feb 8, 2022
...preferences/shared_preferences_windows/example/integration_test/shared_preferences_test.dart
Outdated
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Feb 8, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, sorry I kept missing things in earlier review stages.
BeMacized
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 10, 2022
…mplementation in native packages. (flutter/plugins#4723)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
…mplementation in native packages. (flutter/plugins#4723)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
…mplementation in native packages. (flutter/plugins#4723)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2022
…mplementation in native packages. (flutter/plugins#4723)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eliminates the use of the shared method channel implementation in each of the native packages for the shared_preferences plugin.
This PR's contents are based on the steps outlined in the following issue:
No CHANGELOG change: The main package only has one of its tests changed.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).