This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera]skip app delegate during unit test#4729
Merged
fluttergithubbot merged 3 commits intoflutter:mainfrom Feb 9, 2022
Merged
[camera]skip app delegate during unit test#4729fluttergithubbot merged 3 commits intoflutter:mainfrom
fluttergithubbot merged 3 commits intoflutter:mainfrom
Conversation
hellohuanlin
force-pushed
the
camera_unit_test_app_delegate
branch
3 times, most recently
from
99dda0b to
5eac3c3
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
hellohuanlin
requested review from
cyanglaz,
jmagman and
stuartmorgan-g
and removed request for
bparrishMines
stuartmorgan-g
suggested changes
Feb 8, 2022
hellohuanlin
force-pushed
the
camera_unit_test_app_delegate
branch
3 times, most recently
from
7cec964 to
59b4142
Compare
hellohuanlin
force-pushed
the
camera_unit_test_app_delegate
branch
from
59b4142 to
a06696d
Compare
Contributor
|
test-exempt: untestable (changes logic specifically for tests) |
hellohuanlin
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that during unit tests there are some code in app delegate that eventually setup the FLTCam in background thread, which runs concurrently with normal unit tests in main thread, making breakpoint a bit confusing when debugging.
This PR skips unnecessary
didFinishLaunchingsetups for unit tests.No version change: only affect Runner app's unit tests.
No unit tests: I don't think OCMock supports stubbing global functions. Just manually tested.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.