Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Manually roll to latest Flutter#4736

Merged
fluttergithubbot merged 1 commit intoflutter:mainfrom
stuartmorgan-g:roll-master-pin
Feb 4, 2022
Merged

[ci] Manually roll to latest Flutter#4736
fluttergithubbot merged 1 commit intoflutter:mainfrom
stuartmorgan-g:roll-master-pin

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Feb 4, 2022

Temporarily removes an usused mock method in webview_flutter for a
method whose return type has changed on Flutter master.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[ci] Manually roll to latest Flutter
848f1df 
Temporarily removes an usused mock method in webview_flutter for a
method whose return type has changed on Flutter master.
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 4, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-web labels Feb 4, 2022
@stuartmorgan-g stuartmorgan-g requested a review from ditman February 4, 2022 17:17
ditman
ditman approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

(Created this for the cleanup of the mock later: flutter/flutter#97815)

@ditman ditman added last mile waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labels Feb 4, 2022
@fluttergithubbot fluttergithubbot merged commit c808ab8 into flutter:main Feb 4, 2022
@stuartmorgan-g stuartmorgan-g deleted the roll-master-pin branch February 4, 2022 18:26
@Hixie
Copy link
Contributor

Hixie commented Feb 4, 2022

test-exempt: code refactor with no semantic change

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 7, 2022
@engine-flutter-autoroll
c808ab8 [ci] Manually roll to latest Flutter (flutter/plugins#4736)
701bf29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
c808ab8 [ci] Manually roll to latest Flutter (flutter/plugins#4736)
43e7118
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ditman ditman ditman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests p: webview_flutter Edits files for a webview_flutter plugin platform-web waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stuartmorgan-g @Hixie @ditman @fluttergithubbot