This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[ci] Run analysis with older versions of Flutter#5000
Merged
fluttergithubbot merged 15 commits intoflutter:mainfrom Mar 9, 2022
Merged
[ci] Run analysis with older versions of Flutter#5000fluttergithubbot merged 15 commits intoflutter:mainfrom
fluttergithubbot merged 15 commits intoflutter:mainfrom
Conversation
…es that would be skipped
stuartmorgan-g
force-pushed
the
analyze-old-flutter
branch
from
3614314 to
d397524
Compare
Contributor
Author
|
This should be ready for review (I'll just need to re-push to get |
bparrishMines
approved these changes
Mar 8, 2022
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM with a nit
(forgot to add nit in last review)
ditman
approved these changes
Mar 8, 2022
.cirrus.yml
Outdated
Comment on lines
+151
to
+155
| matrix: | ||
| CHANNEL: "2.5.3" | ||
| CHANNEL: "2.8.1" | ||
| analyze_script: | ||
| - ./script/tool_runner.sh analyze --skip-not-supporting-flutter-version="$CHANNEL" --custom-analysis=script/configs/custom_analysis.yaml |
Member
There was a problem hiding this comment.
This is great stuff! Thanks for adding this configurability to the package_looping_command!
stuartmorgan-g
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a sanity check to reduce accidentally publishing plugins that claim to work on versions we no longer officially support, but with Flutter pubspec constraints that will cause them to be picked up by old versions, this runs
analyzewith the previous two stable releases. While this won't catch all possible issues (runtime failures, use of new Flutter APIs in native code), it will catch a whole category of such errors with relatively little additional CI cost.While this does require manual updates to pubspec.yaml periodically, since this is best-effort testing such updates aren't time-critical, as the impact of forgetting is minimal.
Restructures the tool's analyze command to run
flutter packages getduring package iteration, instead of pre-iterating everything, to allow for skipping packages by version without having to duplicate logic. (This also has the advantage that failures in that step will be assigned to the specific package that causes the problem, as with most failures, rather than a generic step as it was previously doing.)No version change: Dropping support for older versions of Flutter doesn't need a release, just to be applied to future releases.
Part of flutter/flutter#98697
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).