Add dependabot for Gradle dependencies by blasten · Pull Request #5440 · flutter/plugins

blasten · 2022-04-28T23:41:52Z

Adds dependabot for Gradle dependencies.

Unfortunately, dependabot doesn't support globs patterns in directory.

domesticmouse · 2022-04-29T00:24:27Z

.github/dependabot.yml

+  - package-ecosystem: "gradle"
+    directory: "/packages/flutter_plugin_android_lifecycle/example/android/app"
+    schedule:
+      interval: "weekly"


FWIW, I'd suggest making the interval daily, just to spread out the dependabot PRs

stuartmorgan-g

Nice!

Should we put a commit-message entry to do the [plugin_name] prefix?

stuartmorgan-g · 2022-04-29T02:13:57Z

.github/dependabot.yml

+version: 2
+updates:
+  - package-ecosystem: "gradle"
+    directory: "/packages/flutter_plugin_android_lifecycle/example/android/app"


Will checking the examples transitively check and update the plugin dependencies themselves?

I don't think so. It's not very smart from what I can tell

stuartmorgan-g · 2022-04-29T02:15:10Z

.github/dependabot.yml

+    open-pull-requests-limit: 10
+
+  - package-ecosystem: "gradle"
+    directory: "/packages/webview_flutter/webview_flutter/example/android/app"


We should order this file alphabetically by directory so we can easily see what's there.

stuartmorgan-g · 2022-04-29T02:16:19Z

.github/dependabot.yml

+    open-pull-requests-limit: 10
+
+  - package-ecosystem: "gradle"
+    directory: "/packages/webview_flutter/webview_flutter/example/android/app"


Speaking of which, the _android package is missing here.

stuartmorgan-g · 2022-04-29T02:16:33Z

.github/dependabot.yml

+    open-pull-requests-limit: 10
+
+  - package-ecosystem: "gradle"
+    directory: "/packages/connectivity/connectivity/example/android/app"


This plugin doesn't exist any more.

stuartmorgan-g · 2022-04-29T02:17:13Z

.github/dependabot.yml

+    open-pull-requests-limit: 10
+
+  - package-ecosystem: "gradle"
+    directory: "/packages/video_player/video_player_android/example/android/app"


The app-facing package is missing.

With only a couple of exceptions, there should be two examples for every plugin.

stuartmorgan-g · 2022-04-29T02:17:36Z

.github/dependabot.yml

+    open-pull-requests-limit: 10
+
+  - package-ecosystem: "gradle"
+    directory: "/packages/espresso/example/android/app"


This is a duplicate entry.

stuartmorgan-g

LGTM with more added. I'm not sure I caught everything though.

Given that this is fiddly to get right, and will silently get out of sync with changes (e.g., federating the last couple of plugins), I think I should make tooling that verifies dependabot coverage. It'll be useful when we enable Dart dependabot too.

I'll file an issue for that. (Doesn't need to block yours though).

stuartmorgan-g · 2022-04-30T15:04:12Z

.github/dependabot.yml

+    schedule:
+      interval: "daily"
+    open-pull-requests-limit: 10
+


The app-facing package's example is missing.

url_launcher doesn't have an app-facing package. https://github.com/flutter/plugins/tree/main/packages/url_launcher/url_launcher

stuartmorgan-g · 2022-04-30T15:05:24Z

.github/dependabot.yml

+    open-pull-requests-limit: 10
+
+  - package-ecosystem: "gradle"
+    directory: "/packages/path_provider/path_provider_android/example/android/app"


The plugin is missing.

stuartmorgan-g · 2022-04-30T15:06:12Z

.github/dependabot.yml

+    open-pull-requests-limit: 10
+
+  - package-ecosystem: "gradle"
+    directory: "/packages/image_picker/image_picker/example/android/app"


This is missing both parts of the implementation package.

stuartmorgan-g · 2022-04-30T15:06:43Z

.github/dependabot.yml

+    open-pull-requests-limit: 10
+
+  - package-ecosystem: "gradle"
+    directory: "/packages/espresso/example/android/app"


The plugin is missing.

ditman · 2022-05-03T01:08:48Z

This has failed in master with the following:

Your .github/dependabot.yml contained invalid details

Dependabot encountered the following error when parsing your .github/dependabot.yml:

The property '#/updates/4/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/5/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/6/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/7/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/8/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/9/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/10/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/11/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/12/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/13/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/15/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/16/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/17/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/18/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/21/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/22/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/23/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/24/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/26/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/27/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/28/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/29/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/31/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/32/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/33/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/34/commit-message/prefix' was not of a maximum string length of 15
The property '#/updates/35/commit-message/prefix' was not of a maximum string length of 15

Please update the config file to conform with Dependabot's specification.

For more info on the config file format, see the config file documentation

ditman · 2022-05-03T01:21:49Z

Cool way of regexing the baddies:

prefix: "\[[^\]]{14,}\]"

Add dependabot for Gradle dependencies

468c5aa

blasten requested review from GaryQian and camsim99 April 28, 2022 23:42

domesticmouse reviewed Apr 29, 2022

View reviewed changes

weekly -> daily

717a92c

domesticmouse approved these changes Apr 29, 2022

View reviewed changes

stuartmorgan-g suggested changes Apr 29, 2022

View reviewed changes

Comments

67236d7

blasten requested a review from stuartmorgan-g April 30, 2022 02:03

stuartmorgan-g approved these changes Apr 30, 2022

View reviewed changes

stuartmorgan-g mentioned this pull request Apr 30, 2022

[flutter_plugin_tools] add Dependabot coverage check flutter/flutter#102878

Closed

Add missing entries

5135ac4

blasten force-pushed the dependabot branch from 2ac7808 to 5135ac4 Compare May 2, 2022 23:29

blasten added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 2, 2022

fluttergithubbot merged commit cd89420 into flutter:main May 3, 2022

ditman mentioned this pull request May 3, 2022

[ci] Shorten dependabot prefixes to comply with config spec. #5474

Merged

11 tasks

engine-flutter-autoroll mentioned this pull request May 3, 2022

Roll Plugins from bbcb88d3bae4 to 60b0b2d31ee0 (14 revisions) flutter/flutter#102979

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 3, 2022

cd89420e3 Add dependabot for Gradle dependencies (flutter/plugins#5440)

383788a

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

Add dependabot for Gradle dependencies (flutter#5440)

2d00a6c

Conversation

blasten commented Apr 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ditman commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Your .github/dependabot.yml contained invalid details

Uh oh!

ditman commented May 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ditman commented May 3, 2022 •

edited

Loading