This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter_android] Updates Android implementation to deallocate native resources automatically#6428
Merged
bparrishMines merged 15 commits intoflutter:v4_webviewfrom Sep 21, 2022
Conversation
github-actions
bot
added
p: webview_flutter
bparrishMines
changed the title
Contributor
Author
|
@mvanbeusekom This PR will most likely break your v4 android implementation PR, but this should relieve you of needing to handle calling release on objects. |
bparrishMines
commented
Sep 15, 2022
| }); | ||
| }); | ||
|
|
||
| group('WebViewAndroidWebViewClient', () { |
Contributor
Author
There was a problem hiding this comment.
This class no longer exist since we don't need to override WebViewClient to set the callback methods. It's functionality is covered by other tests.
packages/webview_flutter/webview_flutter_android/lib/src/android_webview.dart
Show resolved
Hide resolved
bparrishMines
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#107199
I also manually verified the
WebViewClientis disposed, so the other class should also work.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.