This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] Use const instead of final for XTypeGroup.#6542
Merged
auto-submit[bot] merged 11 commits intoflutter:mainfrom Oct 6, 2022
Merged
[file_selector] Use const instead of final for XTypeGroup.#6542auto-submit[bot] merged 11 commits intoflutter:mainfrom
auto-submit[bot] merged 11 commits intoflutter:mainfrom
Conversation
Version pump for file_selector_platform_interface
Version pump for file_selector_platform_interface
Version pump for file_selector_platform_interface
Version pump for file_selector_platform_interface
Version pump for file_selector_platform_interface
Version pump for file_selector_platform_interface
eugerossetto
requested review from
cbracken,
ditman,
jmagman and
stuartmorgan-g
as code owners
stuartmorgan-g
suggested changes
Oct 6, 2022
| @@ -1,3 +1,7 @@ | |||
| ## NEXT | |||
|
|
|||
| * Changes XTypeGroup initialization from final to const. | |||
Contributor
There was a problem hiding this comment.
This test-only change doesn't need a CHANGELOG entry, so this file can be reverted.
| @@ -14,15 +11,9 @@ void main() { | |||
| group('acceptedTypesToString', () { | |||
| test('works', () { | |||
| final List<XTypeGroup> acceptedTypes = <XTypeGroup>[ | |||
Contributor
There was a problem hiding this comment.
Throughout the changes in this package, can't these lists be const instead of each item in the list?
Contributor
Author
There was a problem hiding this comment.
Yes, you are right. It's doable and better.
stuartmorgan-g
approved these changes
Oct 6, 2022
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM
@ditman for second approval
Contributor
It'll do in a pinch 😉 Thanks! |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final step of this issue, removing all the
//ignore's that were added and converting XTypeGroup toconstinstead offinal.The version of
file_selector_platform_interfacewas upgraded to 2.2.0 in thepubspec.yamlfor all the platforms.Issue:
#111906 [file_selector]
XTypeGroupshould be immutableRelated PR's:
#6476 Convert XTypeGroup to const
#6463 Annotate all creation of XTypeGroup with // ignore: prefer_const_contructor
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.