[shared_preferences] fix typo#6570
[shared_preferences] fix typo#6570auto-submit[bot] merged 3 commits intoflutter:mainfrom HosamHasanRamadan:patch-1
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Good catch on that typo. Make sure you sign the cla, as mentioned by the bot above. Also, the version change, and changelog can be fixed with a simple command mentioned here https://github.com/flutter/plugins/tree/main/script/tool#update-changelog-and-version |
|
Thanks for the contribution! You haven’t checked off any of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review. |
|
I updated the changelog. |
|
@HosamHasanRamadan It looks like you used two different email addresses for the two commits, and have only signed the CLA for one of them. You'll need to either amend the commit or sign for the other address before we can review this. |
Done. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks! This will just need a version change, as explained in our contributing docs.
Done |
Replaced
macOSwithAndroidPre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.