Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[shared_preferences] fix typo#6570

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
HosamHasanRamadan:patch-1
Oct 14, 2022
Merged

[shared_preferences] fix typo#6570
auto-submit[bot] merged 3 commits intoflutter:mainfrom
HosamHasanRamadan:patch-1

Conversation

@HosamHasanRamadan
Copy link
Contributor

@HosamHasanRamadan HosamHasanRamadan commented Oct 13, 2022

Replaced macOS with Android

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Replaced `macOS` with 'Android'
@google-cla
Copy link

google-cla bot commented Oct 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@HosamHasanRamadan HosamHasanRamadan changed the title fix typo [shared_preferences] fix typo Oct 13, 2022
@tarrinneal
Copy link
Contributor

Good catch on that typo. Make sure you sign the cla, as mentioned by the bot above.

Also, the version change, and changelog can be fixed with a simple command mentioned here https://github.com/flutter/plugins/tree/main/script/tool#update-changelog-and-version

@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! You haven’t checked off any of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft October 13, 2022 20:10
@HosamHasanRamadan HosamHasanRamadan marked this pull request as ready for review October 13, 2022 21:29
@HosamHasanRamadan
Copy link
Contributor Author

I updated the changelog.

@stuartmorgan-g
Copy link
Contributor

@HosamHasanRamadan It looks like you used two different email addresses for the two commits, and have only signed the CLA for one of them. You'll need to either amend the commit or sign for the other address before we can review this.

@HosamHasanRamadan
Copy link
Contributor Author

@HosamHasanRamadan It looks like you used two different email addresses for the two commits, and have only signed the CLA for one of them. You'll need to either amend the commit or sign for the other address before we can review this.

Done.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will just need a version change, as explained in our contributing docs.

@HosamHasanRamadan
Copy link
Contributor Author

Thanks! This will just need a version change, as explained in our contributing docs.

Done

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2022
@auto-submit auto-submit bot merged commit 3d44753 into flutter:main Oct 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: shared_preferences platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants