[url_launcher] Adds lint ignores to the usage of RouteInformation.location#7133
[url_launcher] Adds lint ignores to the usage of RouteInformation.location#7133chunhtai wants to merge 1 commit intoflutter:mainfrom
RouteInformation.location#7133Conversation
| @@ -1,6 +1,7 @@ | |||
| ## NEXT | |||
| ## 2.1.2 | |||
There was a problem hiding this comment.
The CHANGELOG and version change should be reverted per https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates (this is a dev-only change, and thus exempt from both).
There was a problem hiding this comment.
I think i need to publish a new version for linux plugin_test to pass? https://github.com/flutter/flutter/pull/119968/checks?check_run_id=11180655690
There was a problem hiding this comment.
Nope, that test is running on a pinned+rolled copy of this repository.
| if (_history.isEmpty) { | ||
| return const Placeholder(key: Key('empty')); | ||
| } | ||
| // TODO(chunhtai): remove the ignore once migration completes. |
There was a problem hiding this comment.
Could you summarize in the comment what "once migration completes" means concretely? The issue you linked to is really long, so it's not immediately obvious.
packages/url_launcher/url_launcher_platform_interface/test/link_test.dart
Show resolved
Hide resolved
stuartmorgan-g
added
override: no versioning needed
chunhtai
force-pushed
the
issues/100624
branch
from
2cf92bc to
b495acf
Compare
|
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
2 participants
flutter framework is about to deprecate RouteInformation.location. Preparing this plugin for soft-transition
Relevant issue: flutter/flutter#100624
Relevant PR: flutter/flutter#119968
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.