[camera] - Fix bug - app crashes on iOS 9#801
[camera] - Fix bug - app crashes on iOS 9#801gisdatasrl wants to merge 1 commit intoflutter:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
063aad0 to
c7100e4
Compare
|
CLAs look good, thanks! |
Enclosed **AVCaptureDeviceDiscoverySession** in a @availabe check and managed older versions with the older versions with the older api Fixes flutter/flutter#20708
c7100e4 to
605d5de
Compare
|
this won't work as the changes are not handling other |
|
I'm going through some old PRs to see what we can do with them. First, sorry for dropping this on the floor, we do appreciate your contributions though apparently we don't do a good job of showing it. For this PR specifically, I'm going to close it because it is lacking tests and all our PRs need to have tests. |
Enclosed AVCaptureDeviceDiscoverySession in a @availabe check and managed older versions with the older versions with the older api
Fixes flutter/flutter#20708