This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Add the ability to disable audio for video recording and image streaming#837
Merged
bparrishMines merged 7 commits intoflutter:masterfrom May 16, 2019
Merged
Conversation
viniciuslrangel
force-pushed
the
camera_audio
branch
from
cfc1b35 to
5e78847
Compare
Option to disable audio Avoids requesting unnecessary permissions, especially when using the camera only for photos
viniciuslrangel
force-pushed
the
camera_audio
branch
from
5e78847 to
83235e4
Compare
Contributor
|
possibly redundant with #904 |
|
What's the status of this PR? |
Contributor
Author
I didn't test on iOS, but I'm using on Android for a while and works great. |
Contributor
|
Hi @viniciuslrangel, Thanks for the contribution! I'm going to take over the PR and try and get the iOS side working. |
bparrishMines
changed the title
bparrishMines
approved these changes
May 16, 2019
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM for Android portion
@mklim can you review the iOS portion since I'm the one that added it?
This was referenced May 16, 2019
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option to disable audio
Avoids requesting unnecessary permissions, especially when using the camera only for photos
Android implementation only