Update navigation_and_routing sample to go_router 5#1437
Closed
johnpryan wants to merge 2 commits intoflutter:mainfrom
johnpryan:navigation-and-routing-update
Closed
Update navigation_and_routing sample to go_router 5#1437johnpryan wants to merge 2 commits intoflutter:mainfrom johnpryan:navigation-and-routing-update
navigation_and_routing sample to go_router 5#1437johnpryan wants to merge 2 commits intoflutter:mainfrom
johnpryan:navigation-and-routing-update
Conversation
11 tasks
domesticmouse
approved these changes
Sep 21, 2022
| return FadeTransitionPage<dynamic>( | ||
| key: state.pageKey, | ||
| // Use a builder to get the correct BuildContext | ||
| // TODO (johnpryan): remove when https://github.com/flutter/flutter/issues/108177 lands |
Contributor
There was a problem hiding this comment.
Should this PR be blocked on this issue being resolved?
Contributor
|
I'm curious why CI is red, any ideas? |
domesticmouse
changed the title
navigation_and_routing sample to go_router 5
| onTap: (idx) { | ||
| switch (idx) { | ||
| case 1: | ||
| GoRouter.of(context).go('/books/new'); |
Member
There was a problem hiding this comment.
Suggestion: Would it be possible to use context.go() extension function instead of GoRouter.of(context).go? so it aligns with https://pub.dev/packages/go_router/example
Contributor
Author
There was a problem hiding this comment.
That fine with me
5 tasks
Member
|
I wanted to enable Material 3 on this sample, but since I saw this PR open, I didn't want to mess with the work and cause a merge conflict, so I wanted to ask first. How do you prefer me to proceed? |
Contributor
Author
|
Brett, do you see #1437 (comment) as a blocker or should we try to merge this PR? |
johnpryan
added a commit
that referenced
this pull request
Nov 1, 2023
This is a new PR to update the navigation_and_routing sample to the latest version of go_router. It is a based on #1437 --------- Co-authored-by: Brett Morgan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the navigation_and_routing sample to go_router 5.
Depends on flutter/flutter#111981
Pre-launch Checklist
///).