Update navigation_and_routing sample to go_router#2067
Merged
johnpryan merged 10 commits intoflutter:mainfrom Nov 1, 2023
johnpryan:navigation-and-routing-update
Merged
Update navigation_and_routing sample to go_router#2067johnpryan merged 10 commits intoflutter:mainfrom johnpryan:navigation-and-routing-update
johnpryan merged 10 commits intoflutter:mainfrom
johnpryan:navigation-and-routing-update
Conversation
parlough
reviewed
Oct 25, 2023
Contributor
Author
|
@domesticmouse @parlough PTAL |
Contributor
|
Looks like the CI is cranky: Analyzing navigation_and_routing...
warning - lib/src/screens/authors.dart:11:7 - This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: AuthorsScreen.onTap - must_be_immutable
warning - lib/src/screens/books.dart:6:8 - Unused import: 'package:go_router/go_router.dart'. Try removing the import directive. - unused_import
info - lib/src/app.dart:61:17 - The 'child' argument should be last in widget constructor invocations. Try moving the argument to the end of the argument list. - sort_child_properties_last
3 issues found. |
domesticmouse
approved these changes
Nov 1, 2023
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
LGTM once CI passes
parlough
approved these changes
Nov 1, 2023
Member
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Looks good to me after one fix.
Please do consider updating the README for the new state of the sample though. Or stripping out the outdated parts :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new PR to update the navigation_and_routing sample to the latest version of go_router. It is a based on #1437