Disable DanTup_tiler.test until golden images can be updated#36
Merged
jason-simmons merged 1 commit intoflutter:masterfrom May 2, 2020
Merged
Disable DanTup_tiler.test until golden images can be updated#36jason-simmons merged 1 commit intoflutter:masterfrom
jason-simmons merged 1 commit intoflutter:masterfrom
Conversation
Contributor
|
If this is just temporary (for a few hours) we should just rename it to LGTM. |
Hixie
previously approved these changes
May 1, 2020
jason-simmons
force-pushed
the
fix_roll_050120
branch
from
9fa83b2 to
81a2a45
Compare
New Windows engine binaries built with Clang result in diffs of a few pixels when running this test. The test will be disabled until the engine roll with these changes lands and the test can be updated to point to the new golden images.
jason-simmons
force-pushed
the
fix_roll_050120
branch
from
81a2a45 to
8c2319b
Compare
Member
Author
|
Updated the test file name |
Hixie
approved these changes
May 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Windows engine binaries built with Clang result in diffs of a few
pixels when running this test. The test will be disabled until the
engine roll with these changes lands and the test can be updated to
point to the new golden images.