Skip to content

Update rainbowmonkey.test#43

Merged
chunhtai merged 2 commits intoflutter:masterfrom
pedromassango:patch-1
Jul 27, 2020
Merged

Update rainbowmonkey.test#43
chunhtai merged 2 commits intoflutter:masterfrom
pedromassango:patch-1

Conversation

@pedromassango
Copy link
Member

@pedromassango pedromassango commented Jul 20, 2020

This PR is a follow up of flutter/flutter#61648 to make tests of that PR to pass.

I've just updated a customer's tests to point to the latest commit introduced by jocosocial/rainbowmonkey#329.

@pedromassango
Copy link
Member Author

Cc: @Hixie

@Hixie
Copy link
Contributor

Hixie commented Jul 21, 2020

I don't see the failure in the logs, weird.

LGTM once we have fixed whatever is causing the failure...

@Hixie
Copy link
Contributor

Hixie commented Jul 21, 2020

Some sort of problem with the gallery tests?:

Processing ./registry/flutter_gallery.test...
Created temporary directory: /tmp/flutter_customer_testing.flutter_gallery.AYIVVE
>> git -c core.longPaths=true clone https://github.com/flutter/gallery.git tests
| Cloning into 'tests'...
>> git -c core.longPaths=true -C tests checkout b22eb190a66a5fb61fcafcc5fa66723f37e17723
| fatal: reference is not a tree: b22eb190a66a5fb61fcafcc5fa66723f37e17723
ERROR: Failed to fetch repository.
Contacts: [email protected], [email protected]
Deleting temporary directory...

@pedromassango
Copy link
Member Author

Thanks. I will keep my eyes on this.

@chunhtai
Copy link
Contributor

chunhtai commented Jul 24, 2020

@pedromassango Please rebase your branch off the master branch to fix the test failure

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants